Commit Graph

67908 Commits

Author SHA1 Message Date
Robin Dunn
c532edfe67 Fix class names in the header 2020-04-02 12:51:16 -07:00
Robin Dunn
52d4bad3df Apply suggestions from code review
Co-Authored-By: VZ <vadim@wxwidgets.org>
2020-04-02 12:35:58 -07:00
Robin Dunn
6039be5291 More documentation updates 2020-04-01 15:27:34 -07:00
Robin Dunn
fb69a2975f Add missing wxOVERRIDE, and some other cleanup 2020-04-01 14:55:08 -07:00
Robin Dunn
6b6a930e9c Update GTK animation classes for the new pattern 2020-04-01 14:16:15 -07:00
Robin Dunn
f641601ea9 Remove the wxOVERRIDEs too 2020-04-01 13:37:38 -07:00
Robin Dunn
1cf191f5d6 Update docs 2020-04-01 13:31:03 -07:00
Robin Dunn
085f08aefe Remove the generic-specific methods from the wxAnimation API 2020-04-01 13:30:49 -07:00
Robin Dunn
cd74255da3 Ensure the animation is ok before getting its impl 2020-04-01 12:58:35 -07:00
Robin Dunn
606f365ea3 Verify the animation impl type matches the animation ctrl type 2020-04-01 12:39:48 -07:00
Robin Dunn
e464453073 * Switch wxAnimation to be a facade over a wxAnimationImpl class.
* Implement wxAnimationGenericImpl
* Update wxGenericAnimationCtrl as needed
2020-04-01 11:53:19 -07:00
Robin Dunn
85bd16fb06 Trim trailing whitespace 2020-03-31 14:02:39 -07:00
Robin Dunn
aa30a6d46e commit suggested change
Co-Authored-By: VZ <vadim@wxwidgets.org>
2020-03-31 13:53:56 -07:00
Robin Dunn
f3b916a99e commit suggested change
Co-Authored-By: VZ <vadim@wxwidgets.org>
2020-03-31 13:26:51 -07:00
Robin Dunn
e72793abec IsOk is pure virtual 2020-03-30 15:44:32 -07:00
Robin Dunn
f13c3dc1ec Documentation updates for Animation classes 2020-03-30 15:26:52 -07:00
Robin Dunn
1608fde659 Add a Create method to the shim class 2020-03-30 15:20:19 -07:00
Robin Dunn
868154ee90 native wxAnimationCtrl derives from the generic class 2020-03-30 15:01:21 -07:00
Robin Dunn
a7f9d5e3c5 * Switch back to using an wxAnimationBase class
* Change the [GS]etAnimation methods to be non-virtual so they can use generic/native types of animation obj
2020-03-30 14:53:11 -07:00
Robin Dunn
08ac4dbad6 Name the base animation class wxGenericAnimation with a wxAnimation shim class 2020-03-27 15:53:03 -07:00
Robin Dunn
488084c2f5 Name the base animation class wxGenericAnimation with a wxAnimation shim class 2020-03-27 14:33:11 -07:00
Robin Dunn
fae15d39a6 * Rename the generic version as wxGenericAnimationCtrl
* Add a simple shim class for the generic wxAnimationCtrl
* Use the generic wxAnimation as the base class (this will probably change...)
2020-03-25 16:29:34 -07:00
Robin Dunn
f501177857 Run autoconf 2020-03-25 14:05:06 -07:00
Robin Dunn
1fa74df7f4 Remove --disable-nativeanimation and wxUSE_NATIVE_ANIMATIONCTRL 2020-03-25 14:03:28 -07:00
Vadim Zeitlin
2c7924dd2e Remove the now unused UNIV_PLATFORM_{SRC,HDR} variables
They used to contain animation-related files, but are empty now and can
be simply removed.
2020-03-25 13:58:57 +01:00
Vadim Zeitlin
842e185f3b Move generic files to common sources/headers in the right place
This corresponds to the changes already manually done in
build/bakefiles/files.bkl but is now done in the right file and so also
for CMake-based build system.
2020-03-25 13:57:39 +01:00
Vadim Zeitlin
c7084c8868 Rerun bakefile after wxAnimationCtrl-related changes 2020-03-25 12:22:45 +01:00
Vadim Zeitlin
636729bd34 Update CMake version of setup.h header too
This is the result of running build/update-setup-h too.
2020-03-25 12:20:47 +01:00
Vadim Zeitlin
360867d37b Remove extra accidentally added blank line in auto-generated file
Just commit the result after running build/update-setup-h.
2020-03-25 12:20:18 +01:00
Robin Dunn
7468e7c8a8 Add text to wxAnimation docs about how to use the generic version on wxGTK 2020-03-24 19:58:04 -07:00
Robin Dunn
201af608f7 Update description of wxUSE_NATIVE_ANIMATIONCTRL 2020-03-24 19:43:13 -07:00
Robin Dunn
8c87c1ec03 Remove check for __WXUNIVERSAL__
Co-Authored-By: VZ <vadim@wxwidgets.org>
2020-03-24 19:31:46 -07:00
Vadim Zeitlin
99f79b4495 Revert "Run bakefile"
This reverts commit fea3d52505.
2020-03-25 02:59:07 +01:00
Robin Dunn
357f792971 Split decoder interface to match the actual header files 2020-03-24 17:32:12 -07:00
Robin Dunn
f3cd24ee35 Fix interface filename, remove duplicate enum 2020-03-24 17:02:48 -07:00
Robin Dunn
4942ee99f6 Update the interface files for the animation classes 2020-03-24 16:25:30 -07:00
Robin Dunn
eeedc14a58 DoCanRead is protected in the base class, make it the same in derived classes. 2020-03-24 16:25:00 -07:00
Robin Dunn
fea3d52505 Run bakefile 2020-03-24 14:51:51 -07:00
Robin Dunn
398b178431 Compile native or generic animation classes based on wxUSE flags 2020-03-24 14:49:03 -07:00
Robin Dunn
86fbadb52e Move generic animate files to GUI_CMN 2020-03-24 13:36:55 -07:00
Robin Dunn
d72ef11e87 Add --disable-nativeanimation configure option, and wxUSE_NATIVE_ANIMATIONCTRL 2020-03-24 13:19:34 -07:00
Robin Dunn
501e55f949 Add missing wxMemoryDC::GetSelectedBitmap 2020-03-23 20:17:22 -07:00
Vadim Zeitlin
eb0b4af073 Merge branch 'travis-test-fail'
Run "make failtest" in Travis CI builds.

See https://github.com/wxWidgets/wxWidgets/pull/1767
2020-03-24 03:24:00 +01:00
Vadim Zeitlin
ebb6f89e13 Fix wxMSW build error with wxUSE_UXTHEME==0
Explicitly include <commctrl.h> instead of relying on it being done
implicitly by wx/msw/uxtheme.h, as this doesn't happen when
wxUSE_UXTHEME is 0.

Closes #18702.
2020-03-24 03:22:13 +01:00
Vadim Zeitlin
2a2faa73ea Correct wx/msw/setup.h instructions in the documentation
This file doesn't need to be created initially, as it will be done
automatically during the build, but it does need to be updated whenever
setup0.h changes, so explain this in both the README-GIT.md file and the
main build instructions.

Closes #18699.
2020-03-24 03:19:38 +01:00
Vadim Zeitlin
98206975f5 Run compilation failures tests on Travis
"failtest" target is not built by default and it's not trivial to change
this, as it needs to be built before anything else (and not in parallel
with it, as otherwise object files created while building the tests
could be removed), so just build it manually before building the tests
themselves in Travis CI builds (or at least those of them using
configure and make).
2020-03-24 00:02:38 +01:00
Vadim Zeitlin
7696fa1bb7 Mark failtest_xxx targets as phony
This doesn't really change anything, but is more correct, as the targets
names don't correspond to any physical files.
2020-03-24 00:01:15 +01:00
Vadim Zeitlin
335565076e Fix event propagation test build for !wxUSE_DOC_VIEW_ARCHITECTURE
Avoid compiling the test using wxDocument etc when they're not
available.

Closes #18700.
2020-03-19 01:16:52 +01:00
Vadim Zeitlin
9b36924258 Merge branch 'generic-treectrl-fixes'
Several improvements to generic wxTreeCtrl.

See https://github.com/wxWidgets/wxWidgets/pull/1765
2020-03-19 01:13:49 +01:00
Vadim Zeitlin
10c51dbf28 Avoid spurious asserts when holding arrows in GTK wxSpinButton
The change in the value can be greater than 1 when the arrows are held
pressed, contrary to what the logic of determining the wraparound added
in 086793ceef supposed.

Replace this with a check of whether we switch from the min value
directly to the max one or vice versa, which mostly works and avoids
asserts, even if it can still fail and produces wrong events when the
arrows are held pressed for long enough to increase the delta to the
range of the control, in which case we just can't distinguish between
wraparound and passing from min to max (or vice versa) in a single step,
which means that we have no way to determine the right event to send.
But producing a wrong event is better than asserting, so this still
counts as an improvement.

Closes https://github.com/wxWidgets/wxWidgets/pull/1764

See #17957.

Closes #18695.
2020-03-19 01:11:06 +01:00