Amebis/BesService
2
2
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Ensure that entire mistake is highlighted, including parts spanning in multiple lines #2

Browse Source
This commit is contained in:
Aljaž Grilc 2025-01-13 11:59:01 +01:00
parent 14e4893b8d
commit 9bfefe6906
1 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
service.js
View File

@ -426,14 +426,26 @@ class BesService {
* @param {*} match Grammar checking rule match * @param {*} match Grammar checking rule match
* @param {PointerEvent} source Click event source * @param {PointerEvent} source Click event source
*/ */
popupCorrectionPanel(el, match, source, highlightEl) { popupCorrectionPanel(el, match, source) {
const popup = document.querySelector('bes-popup-el') const popup = document.querySelector('bes-popup-el')
popup.changeMessage(match.match.message)
popup.appendReplacements(el, match, this, this.isContentEditable())
this.highlightMistake(match)
popup.show(source.clientX, source.clientY)
}
/**
* Removes previously highlighted grammar mistake and highlights new one.
*
* @param {*} match Grammar checking rule match
*/
highlightMistake(match) {
document.querySelectorAll('.bes-mistake-highlight-selected').forEach(el => { document.querySelectorAll('.bes-mistake-highlight-selected').forEach(el => {
el.classList.remove('bes-mistake-highlight-selected') el.classList.remove('bes-mistake-highlight-selected')
}) })
popup.changeMessage(match.match.message) match.highlights.forEach(h =>
popup.appendReplacements(el, match, this, this.isContentEditable()) h.classList.add('bes-mistake-highlight-selected')
popup.show(source.clientX, source.clientY, highlightEl) )
} }
/** /**
@ -871,7 +883,7 @@ class BesTreeService extends BesService {
h.getBoundingClientRect() h.getBoundingClientRect()
) )
) { ) {
this.popupCorrectionPanel(el, m, source, h) this.popupCorrectionPanel(el, m, source)
return return
} }
} }
@ -1409,7 +1421,7 @@ class BesPlainTextService extends BesService {
h.getBoundingClientRect() h.getBoundingClientRect()
) )
) { ) {
this.popupCorrectionPanel(result.range, m, source, h) this.popupCorrectionPanel(result.range, m, source)
return return
} }
} }
@ -1956,10 +1968,8 @@ class BesPopup extends HTMLElement {
* @param {Number} x X location hint * @param {Number} x X location hint
* @param {Number} y Y location hint * @param {Number} y Y location hint
*/ */
show(x, y, highlightEl) { show(x, y) {
this.style.position = 'fixed' this.style.position = 'fixed'
this.highlightEl = highlightEl
this.highlightEl.classList.add('bes-mistake-highlight-selected')
// Element needs some initial placement for the browser to provide this.offsetWidth and this. // Element needs some initial placement for the browser to provide this.offsetWidth and this.
// offsetHeight measurements. // offsetHeight measurements.