From 9bfefe6906959a81f627bccaf5c7e507360256b3 Mon Sep 17 00:00:00 2001
From: Aljaz Grilc <aljaz.grilc@amebis.si>
Date: Mon, 13 Jan 2025 11:59:01 +0100
Subject: [PATCH] refactor: Ensure that entire mistake is highlighted,
 including parts spanning in multiple lines #2

---
 service.js | 28 +++++++++++++++++++---------
 1 file changed, 19 insertions(+), 9 deletions(-)

diff --git a/service.js b/service.js
index 58b2f62..552e2d9 100644
--- a/service.js
+++ b/service.js
@@ -426,14 +426,26 @@ class BesService {
    * @param {*} match Grammar checking rule match
    * @param {PointerEvent} source Click event source
    */
-  popupCorrectionPanel(el, match, source, highlightEl) {
+  popupCorrectionPanel(el, match, source) {
     const popup = document.querySelector('bes-popup-el')
+    popup.changeMessage(match.match.message)
+    popup.appendReplacements(el, match, this, this.isContentEditable())
+    this.highlightMistake(match)
+    popup.show(source.clientX, source.clientY)
+  }
+
+  /**
+   * Removes previously highlighted grammar mistake and highlights new one.
+   *
+   * @param {*} match Grammar checking rule match
+   */
+  highlightMistake(match) {
     document.querySelectorAll('.bes-mistake-highlight-selected').forEach(el => {
       el.classList.remove('bes-mistake-highlight-selected')
     })
-    popup.changeMessage(match.match.message)
-    popup.appendReplacements(el, match, this, this.isContentEditable())
-    popup.show(source.clientX, source.clientY, highlightEl)
+    match.highlights.forEach(h =>
+      h.classList.add('bes-mistake-highlight-selected')
+    )
   }
 
   /**
@@ -871,7 +883,7 @@ class BesTreeService extends BesService {
               h.getBoundingClientRect()
             )
           ) {
-            this.popupCorrectionPanel(el, m, source, h)
+            this.popupCorrectionPanel(el, m, source)
             return
           }
         }
@@ -1409,7 +1421,7 @@ class BesPlainTextService extends BesService {
               h.getBoundingClientRect()
             )
           ) {
-            this.popupCorrectionPanel(result.range, m, source, h)
+            this.popupCorrectionPanel(result.range, m, source)
             return
           }
         }
@@ -1956,10 +1968,8 @@ class BesPopup extends HTMLElement {
    * @param {Number} x X location hint
    * @param {Number} y Y location hint
    */
-  show(x, y, highlightEl) {
+  show(x, y) {
     this.style.position = 'fixed'
-    this.highlightEl = highlightEl
-    this.highlightEl.classList.add('bes-mistake-highlight-selected')
 
     // Element needs some initial placement for the browser to provide this.offsetWidth and this.
     // offsetHeight measurements.