d18d979371
The ScintillaWX::ModifyScrollBars method is used to ensure that the horizontal and vertical scrollbars are constantly up to date. It computes the needed max and page size for the scrollbars based on a combination of input data and internal state variables, compares the needed values with the scrollbar’s current max and page size, and updates the scrollbars if there is a difference. Because of the current logic used, the method will try to update the scroll bars in two cases where no updates are necessary. First, if a scrollbar is not visible (or if word wrapping is on for the horizontal scrollbar), ModifyScrollBars currently tries to set the max to 0. However on some platforms, such as windows, this call can fail and result in the max actually being set to 1. Consequently subsequent calls to ModifyScrollBars will assume the value should be 0 but detect the scrollbar’s max as 1 and try to update the value again. To avoid this, instead set the scrollbar’s page size to 1 more than the max. The second case is only for the horizontal scrollbar. Currently, the function updates the scrollbar whenever the position is not 0. There doesn’t seem to be any reason for this check, and so it has simply been removed. Closes https://github.com/wxWidgets/wxWidgets/pull/1327
About
wxWidgets is a free and open source cross-platform C++ framework for writing advanced GUI applications using native controls.
wxWidgets allows you to write native-looking GUI applications for all the major desktop platforms and also helps with abstracting the differences in the non-GUI aspects between them. It is free for the use in both open source and commercial applications, comes with the full, easy to read and modify, source and extensive documentation and a collection of more than a hundred examples. You can learn more about wxWidgets at https://www.wxwidgets.org/ and read its documentation online at https://docs.wxwidgets.org/
Platforms
This version of wxWidgets supports the following primary platforms:
- Windows XP, Vista, 7, 8 and 10 (32/64 bits).
- Most Unix variants using the GTK+ toolkit (version 2.6 or newer or 3.x).
- OS X (10.7 or newer) using Cocoa (32/64 bits).
Most popular C++ compilers are supported including but not limited to:
- Microsoft Visual C++ 2003 or later (up to 2017).
- g++ 3.4 or later, including MinGW/MinGW-64/TDM under Windows.
- Clang under OS X and Linux.
- Intel icc compiler.
- Oracle (ex-Sun) aCC.
Licence
wxWidgets licence is a modified version of LGPL explicitly allowing not distributing the sources of an application using the library even in the case of static linking.
Building
For building the library, please see platform-specific documentation under
docs/<port> directory, e.g. here are the instructions for
wxGTK, wxMSW and
wxOSX.
If you're building the sources checked out from Git, and not from a released version, please see these additional Git-specific notes.
Further information
If you are looking for community support, you can get it from
- Mailing Lists
- Discussion Forums
- #wxwidgets IRC channel
- Stack Overflow
(tag your questions with
wxwidgets) - And you can report bugs at https://trac.wxwidgets.org/newticket
Commercial support is also available.
Finally, keep in mind that wxWidgets is an open source project collaboratively developed by its users and your contributions to it are always welcome. Please check our guidelines if you'd like to do it.
Have fun!
The wxWidgets Team.