7092b1112e
Creating a font with wxFONTSTYLE_SLANT results in a font whose GetStyle() returned wxFONTSTYLE_ITALIC, so it was never found in the cache, resulting in, effectively, leaking memory and GDI handles because each new call to wxFontList::FindOrCreateFont(...wxFONTSTYLE_SLANT) created a new font. Fix this by just hardcoding that wxFONTSTYLE_SLANT is wxFONTSTYLE_ITALIC under MSW, this is ugly but avoids backwards incompatible (and not obviously correct) change of making wxFont::GetStyle() return wxFONTSTYLE_SLANT if the font was created using this style. Notice that wxFont::GetStyle() does behave like this in wxOSX currently, so there is an inconsistency between ports here. It would arguably be better to make wxOSX behave like wxMSW because the actual font is really italic and not slant/oblique and if we do this, the preprocessor condition in this commit should be extended to cover wxOSX too. Closes #17903.
About
wxWidgets is a free and open source cross-platform C++ framework for writing advanced GUI applications using native controls.
wxWidgets allows you to write native-looking GUI applications for all the major desktop platforms and also helps with abstracting the differences in the non-GUI aspects between them. It is free for the use in both open source and commercial applications, comes with the full, easy to read and modify, source and extensive documentation and a collection of more than a hundred examples. You can learn more about wxWidgets at https://www.wxwidgets.org/ and read its documentation online at http://docs.wxwidgets.org/
Platforms
wxWidgets currently supports the following primary platforms:
- Windows XP, Vista, 7, 8 and 10 (32/64 bits).
- Most Unix variants using the GTK+ toolkit (version 2.6 or newer or 3.x).
- OS X (10.7 or newer) using Cocoa (32/64 bits).
Most popular C++ compilers are supported including but not limited to:
- Microsoft Visual C++ 2003 or later (up to 2017).
- g++ 3.4 or later, including MinGW/MinGW-64/TDM under Windows.
- Clang under OS X and Linux.
- Intel icc compiler.
- Oracle (ex-Sun) aCC.
Licence
wxWidgets licence is a modified version of LGPL explicitly allowing not distributing the sources of an application using the library even in the case of static linking.
Further information
If you are looking for support, you can get it from
- Mailing Lists
- Discussion Forums
- #wxwidgets IRC channel
- Stack Overflow
(tag your questions with
wxwidgets) - Please report bugs at https://trac.wxwidgets.org/newticket
We would also gladly welcome your contributions.
Have fun!
The wxWidgets Team.