Commit Graph

65844 Commits

Author SHA1 Message Date
Vadim Zeitlin
f670cf2d29 Remove stray CR characters from msvc/wx/setup.h
See 46ba9ca2f9 which accidentally added
them.

No real changes.
2019-03-05 23:25:34 +01:00
Cătălin Răceanu
088d698c08 Don't give focus to a frame when clicking outside a focused child
Closes https://github.com/wxWidgets/wxWidgets/pull/1238
2019-02-27 17:17:06 +01:00
Vadim Zeitlin
0b973fb357 Use critical alert style for wxICON_ERROR too in wxOSX
After the changes of 6b8b3ee379 we could
use NSCriticalAlertStyle for message boxes with wxICON_WARNING, if they
also has Yes/No or Cancel button, but never for wxICON_ERROR, for which
just NSWarningAlertStyle was used, which seems counterintuitive, so
change the code to use NSCriticalAlertStyle for either wxICON_WARNING or
wxICON_ERROR message boxes asking the user about something.

Closes https://github.com/wxWidgets/wxWidgets/pull/1242
2019-02-27 01:42:53 +01:00
Paul Cornett
0fc5413974 Call static functions directly 2019-02-25 23:53:51 -08:00
Paul Cornett
393d2c61a7 Fix -Wreorder warning 2019-02-25 23:52:53 -08:00
Paul Cornett
fb1a46b933 Remove test of always-true condition 2019-02-25 23:48:28 -08:00
Paul Cornett
1e753f97ba Remove initializations which are the default value 2019-02-25 10:49:04 -08:00
Paul Cornett
7c3ce912e0 Use ctor-initializer rather than assignment for non-POD class members 2019-02-25 10:23:35 -08:00
Paul Cornett
8df0cfba2a Use pre-increment on iterators 2019-02-25 09:20:44 -08:00
Paul Cornett
b5028f267d Remove unused variables, unused assignments 2019-02-25 09:12:43 -08:00
Maarten Bent
ceee8d554a Fix invalid iterator access in wxTaskBarButton
Iterators are invalid after they are deleted. Store the value before
deleting.

Reuse code of RemoveThumbBarButton.

Closes https://github.com/wxWidgets/wxWidgets/pull/1240
2019-02-25 15:12:45 +01:00
Paul Cornett
5c5f4eb32e Fix format specifier type mismatch 2019-02-25 00:50:19 -08:00
Paul Cornett
60fb8f93cb Check for self-assignment in operator= 2019-02-25 00:48:41 -08:00
Paul Cornett
90ecc401c0 Remove duplicate condition
wxICON_ERROR == wxICON_HAND
2019-02-25 00:44:02 -08:00
Paul Cornett
cd045cc490 Add missing break statements 2019-02-25 00:41:50 -08:00
Paul Cornett
5e3c39043d Fix wxQT monolithic build on Linux
- Remove duplicate wxConsoleAppTraits::CreateEventLoop()
  It's already defined for Unix as well as Windows

- Remove wxEventLoop AddSourceForFD() "override"
  the base version is static and therefore clearly not meant to be overridden
2019-02-25 00:35:27 -08:00
Cătălin Răceanu
0659006dc6 Implement wxListBox::SetFirstItem() for wxQt
Closes https://github.com/wxWidgets/wxWidgets/pull/1236
2019-02-23 15:42:26 +01:00
Vadim Zeitlin
6b73d002d7 Merge branch 'gc-print-font-scale'
Fix size of text drawing using wxGraphicsContext when printing in wxMSW.

See https://github.com/wxWidgets/wxWidgets/pull/1214
2019-02-23 15:40:30 +01:00
Paul Cornett
40c81a6a4a Fix minimum height of backtrace window in wxGTK assert dialog
For GTK3 < 3.10, see #18347
2019-02-23 06:29:54 -08:00
Artur Wieczorek
775b98652f Fix setting minimum height of backtrace window in GtkAssertDialog
Minimum height needs to be set for the entire backtrace window
not for its child tree view.

Closes #18347.
2019-02-23 14:50:29 +01:00
Cătălin Răceanu
0e3784c46e Implement support for value range in wxQt wxSpinButton
Closes https://github.com/wxWidgets/wxWidgets/pull/1237
2019-02-22 19:49:06 +01:00
Vadim Zeitlin
e9813688ad Merge branch 'spinbutton-up-down-events' of https://github.com/catalinr/wxWidgets
Fix wxSpinButton events in wxQt.

See https://github.com/wxWidgets/wxWidgets/pull/1232
2019-02-22 00:03:04 +01:00
Cătălin Răceanu
1af2b7f05a Correct condition check for vetoed events 2019-02-21 19:48:45 +02:00
Vadim Zeitlin
85666cd22f Demonstrate vetoing wxEVT_SPIN_XXX events in widgets sample
Show that these events can be vetoed, which prevents the control value
from changing, and also that veto doesn't apply if the event handler
skips the event.

See https://github.com/wxWidgets/wxWidgets/pull/1232
2019-02-21 15:10:27 +01:00
Cătălin Răceanu
7588ed0cf4 Fix small styling issues in previous 2 commits 2019-02-21 08:19:02 +02:00
Cătălin Răceanu
d9c8932188 Ensure a valid page is initially selected in the widgets sample
Select first page if an invalid one was restored which may happen if the
build of the library has changed (e.g. some previously disabled
wxUSE_XXX became enabled etc).

Closes https://github.com/wxWidgets/wxWidgets/pull/1235
2019-02-21 04:49:12 +01:00
Graham Dawes
d08913edaf Default to wxTB_TOP if no toolbar position is given in wxQt
Qt requires a toolbar area to be specified or the toolbar is not added
to the window, so ensure that is no toolbar flag is given to the wxFrame
then wxTB_TOP is used.

Closes https://github.com/wxWidgets/wxWidgets/pull/1234
2019-02-21 04:47:01 +01:00
Graham Dawes
1e875c8ddc Set the event object and ID in events generated by wxQt
Add missing SetEventObject() calls and ID parameters in the ctor calls
for several events generated by wxQt.

Closes https://github.com/wxWidgets/wxWidgets/pull/1230
2019-02-21 04:35:51 +01:00
Vadim Zeitlin
38d7ba21e2 Merge branch 'tglbtn' of https://github.com/catalinr/wxWidgets
Reimplement wxToggleButton correctly for wxQt.

See https://github.com/wxWidgets/wxWidgets/pull/1228
2019-02-21 04:33:56 +01:00
PB
f8090263de Fix recently introduced mojibake in text sample
During the samples-wide removal of obsolete wxT macros in
f58ea62596, the macros were
accidentally removed also from the place where they were required
(string literal casted to void* and then retrieved as wxChar*). This led
to names for m_tab and m_enter controls displayed wrong when logging
text events.

Fix this by restoring wxS() in this particular place.

See https://github.com/wxWidgets/wxWidgets/pull/945

Closes https://github.com/wxWidgets/wxWidgets/pull/1226
2019-02-21 04:26:46 +01:00
Cătălin Răceanu
0a1846eb9a Use correct event type for wxEVT_SPIN 2019-02-20 16:06:05 +02:00
Cătălin Răceanu
d4b29b3bcc Add support for wxEVT_SPIN_[UP|DOWN] events 2019-02-20 15:39:03 +02:00
Paul Cornett
1229ceb440 Remove unnecessary copy ctor/operator= definitions 2019-02-17 23:09:49 -08:00
Paul Cornett
e08a1d38e1 Use const reference parameter 2019-02-17 22:58:42 -08:00
Paul Cornett
34a3f0512d Remove redundant condtional/unreachable code 2019-02-17 22:55:56 -08:00
Paul Cornett
ff5d764b63 Simplify conditional expression
!A || (A && B) --> !A || B
2019-02-17 22:49:58 -08:00
Paul Cornett
7c75f46098 wxOVERRIDE 2019-02-17 22:42:26 -08:00
Paul Cornett
3b8404ce48 Avoid potential buffer overrun
Need to allow for terminating nul
2019-02-17 22:32:40 -08:00
Paul Cornett
36f742e2e7 Avoid pointless bitwise operation on a bool 2019-02-17 22:28:44 -08:00
Paul Cornett
66f88e401e Avoid potential memory leaks 2019-02-17 22:26:36 -08:00
Paul Cornett
123b96e214 Avoid potential 31-bit shift of signed 32-bit value 2019-02-17 22:22:08 -08:00
Paul Cornett
0cb9231720 Avoid shifting negative value 2019-02-17 22:20:50 -08:00
Paul Cornett
71972a5265 Use pre-increment operator with iterators 2019-02-17 18:48:40 -08:00
Paul Cornett
360342659b Remove unimplemented wxListBase ctor declaration 2019-02-17 18:26:17 -08:00
Paul Cornett
ad59df7355 Remove unuseable wxListBase ctor
It calls Append(void*), which calls the pure virtual CreateNode(), which will
crash, as the required override can't be called from the base class ctor.
2019-02-17 18:19:16 -08:00
Paul Cornett
c41ff4e694 Remove unuseable wxPGArrayEditorDialog ctor
It calls Create(), which calls the pure virtual ArrayGetCount(), which will
crash, as the required override can't be called from the base class ctor.
2019-02-17 18:00:26 -08:00
Paul Cornett
9ea2ac92ef Fix wxCriticalSectionLocker usage
A temporary object will not hold the lock
2019-02-17 17:24:36 -08:00
Pavel Kalugin
be12bc6a8a Fix selection in generic wxDataViewCtrl after adding an item
Notify m_selection about the new item in all cases, not just when using
a virtual list model.

This was broken back in 36a5983f64 and
only fixed for virtual list controls, but not all the other ones, in
9f5af0a494.
2019-02-15 14:39:13 +01:00
Cătălin Răceanu
be9c18cbd6 Reuse Qt implementation of normal button for toggle buttons 2019-02-13 01:23:20 +02:00
Cătălin Răceanu
7be9c8c670 Remove functions that are identical with the ones in base classes 2019-02-13 01:15:19 +02:00