Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
69,699 Commits 1 Branch 330 Tags
af160f3d3eb34b36b93afb1f0958d5e0c51dbaf1
Commit Graph

69699 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vadim Zeitlin
af160f3d3e Use CHECK() when REQUIRE() is not needed in wxWebRequest tests 
Continue performing the other checks unless we really can't do it.
 2021-01-15 15:42:12 +01:00
Vadim Zeitlin
1e8fe318ed Work around wxWebRequest test failure under Ubuntu 14.04 
Ignore wrong status code returned by libcurl on this ancient version,
it's not worth dealing with it.
 2021-01-15 15:40:32 +01:00
Vadim Zeitlin
420160f0a2 Fix format specifier for DWORD in wxWebRequestWinHTTP code 
This fixes assertion failure when running under Win64 due to the size
mismatch between DWORD and size_t on this platform.
 2021-01-15 13:00:19 +01:00
Vadim Zeitlin
ef08d499ce Remove unnecessary SetIgnoreServerErrorStatus() from the API 
It's up to the application code to decide how it handles the HTTP status
codes it gets back from server, there is no need to have a special
method for handling them in wxWebRequest itself.

We also shouldn't skip downloading the response body just because it was
unsuccessful, we may still need it (e.g. it's very common to return the
detailed error description in a JSON object in the message body when
returning some 4xx error), so don't do it in wxMSW implementation and
add a test verifying that we still get the expected body even for an
error status.

Also improve wxWebRequest::State values documentation.
 2021-01-15 03:08:18 +01:00
Vadim Zeitlin
bafbcfa90f Add tracing statements to WinHTTP code too 
This again can be very useful for debugging.
 2021-01-15 02:56:45 +01:00
Vadim Zeitlin
798d2bb080 Accept everything instead of nothing in wxWebRequestWinHTTP 
This is consistent with the other implementations and generally makes
more sense.
 2021-01-15 02:54:30 +01:00
Vadim Zeitlin
f85f716cea Show more information about the request result in manual test 
Show the HTTP status as well as data retrieved by the server.
 2021-01-15 02:52:15 +01:00
Vadim Zeitlin
f9d7a06c37 Fix tags for WebRequest::Manual() unit test 
Don't give it any tags other than "." as we don't want to execute it
when these tags are specified, only when it's explicitly selected by
using its name on the command line.
 2021-01-15 00:56:49 +01:00
Vadim Zeitlin
168408620d Add wxWebRequest::Cancel() unit test 
Check that the request does get cancelled and has the correct state.
 2021-01-15 00:53:45 +01:00
Vadim Zeitlin
4e1bece87e Fix end state of cancelled requests in Mac implementation 
Don't set the state to State_Failed if the request was cancelled.
 2021-01-15 00:53:21 +01:00
Vadim Zeitlin
70e7861a7d Implement authentication support for wxWebRequest under Mac 
Add wxWebAuthChallengeURLSession and use the appropriate delegate
callback to create it.
 2021-01-15 00:46:45 +01:00
Vadim Zeitlin
e80b65b132 Add timeout to wxWebRequest test 
Ensure that the test terminates even if we don't get the expected event.
 2021-01-15 00:45:54 +01:00
Vadim Zeitlin
d2840d2516 Add some wxLogTrace() calls to wxWebRequestURLSession code 
This is helpful when trying to understand what is going on, especially
because CFNETWORK_DIAGNOSTICS, which is supposed to do the same thing at
native level, doesn't seem to work (at least under 10.14).
 2021-01-13 02:04:13 +01:00
Vadim Zeitlin
0ccc6d4047 Remove useless wxWebAuthChallengeCURL::Init() 
This just always returned true, so simply remove it to simplify the
code.
 2021-01-12 19:15:37 +01:00
Vadim Zeitlin
5e8a14ff41 Update dialogs sample to use wxWebCredentials too 
This should have been done in abcc31c6b2 (Update wxCredentialEntryDialog
to use wxWebCredentials, 2021-01-10).
 2021-01-12 14:59:14 +01:00
Vadim Zeitlin
ea3d25336c Fix typo in WXWEBREQUEST_BACKEND documentation 
Thanks codespell.
 2021-01-12 14:53:24 +01:00
Vadim Zeitlin
3f783b15f0 Add another explicit conversion from wxString to "const wchar_t*" 
Fix build in wxUSE_STL=1 configuration.
 2021-01-12 14:52:14 +01:00
Vadim Zeitlin
20a3317839 Rename wxWebRequestEvent::GetResponseFileName() to GetDataFile() 
This is shorter and doesn't imply that just the name (and not the full
path) is being returned.

Also rename wxWebResponse::GetFileName() to GetDataFile() for the same
reasons and for consistency. And document this previously undocumented
method.
 2021-01-12 03:34:40 +01:00
Vadim Zeitlin
d0f56b1d04 Document wxWebResponse::GetContentLength() 
Also change its return type from wxInt64 to wxFileOffset for consistency
with all the other length/progress-related functions in wxWebRequest.
 2021-01-12 03:25:16 +01:00
Vadim Zeitlin
3da03b3b7b Clarify values returned by wxWebRequest progress methods 
Make it clear which values change and which remain constant.
 2021-01-12 03:14:18 +01:00
Vadim Zeitlin
a1e0b7e292 Slightly simplify code removing temporary file 
There is no need to check the state and storage type again when we had
just done it.
 2021-01-12 03:09:56 +01:00
Vadim Zeitlin
67ad831a31 Improve documentation of wxWebRequest storage methods 
Indicate which methods should be used with each storage type to process
the data later.
 2021-01-12 03:09:51 +01:00
Vadim Zeitlin
591d02c979 Increase default buffer size for wxWebRequest operations 
Use 64KiB rather than 8KiB, as the latter seems rather small nowadays.

Also add a symbolic constant for this number.
 2021-01-12 03:00:35 +01:00
Vadim Zeitlin
6c1e1164d9 Remove unnecessary cast to "void*" 
No real changes.
 2021-01-12 02:57:30 +01:00
Vadim Zeitlin
646d8014ec Check if specified HTTP method is incompatible with posting data 
Currently data can be used with POST or PUT HTTP methods only.
 2021-01-12 02:54:13 +01:00
Vadim Zeitlin
7af2f29602 Use more readable CmpNoCase() in wxWebRequestCURL code 
No real changes, just make case-insensitive comparisons more clear.
 2021-01-12 02:52:28 +01:00
Vadim Zeitlin
9a8981241e Check return value of curl_easy_init() 
Normally it is not supposed to fail, but still try not to crash if it
does.
 2021-01-12 02:49:51 +01:00
Vadim Zeitlin
468a961426 Rename methods called from libcurl to use more clear names 
Indicate that they're callbacks used by libcurl rather than normal
methods used by the application code itself.

No real changes.
 2021-01-12 02:40:38 +01:00
Vadim Zeitlin
228d231753 Avoid copying POST data in NSURLSession wxWebRequest code 
Just give the ownership of the buffer to NSData instead of copying it.
 2021-01-12 02:34:18 +01:00
Vadim Zeitlin
5713d17ab0 Clarify asynchronous nature of wxWebRequest::Cancel() in the docs 2021-01-12 02:30:33 +01:00
Vadim Zeitlin
dceb24ad7c Add support for WXWEBREQUEST_BACKEND environment variable 
Defining this variable overrides the default backend choice.

Document the variable itself and also extend wxWebSession::New()
documentation.
 2021-01-12 02:17:39 +01:00
Vadim Zeitlin
d3b93a48b3 Remove wxWebSessionBackendDefault and just use empty string 
There doesn't seem to be any reason to have this constant, so don't
define it and just interpret empty value of backend as meaning to choose
the default one in wxWebSession::New().
 2021-01-12 02:17:31 +01:00
Vadim Zeitlin
3b87af5738 Fix the build when implicit wxString conversions are disabled 
This corrects a bug introduced in 5d256988be (Add wxMSWFormatMessage()
and use it from other places, 2021-01-09).
 2021-01-11 14:18:42 +01:00
Vadim Zeitlin
000856a342 Make wxWebCredentials available even when wxUSE_WEBREQUEST==0 
This fixed build with wxUSE_CREDENTIALDLG==1 but wxUSE_WEBREQUEST==0.

No real changes, this commit just moves the code around.
 2021-01-11 03:16:21 +01:00
Vadim Zeitlin
4986850c63 Rename wxWebSession::SetHeader() to AddCommonHeader() 
The old name wasn't very clear and it was confusing to have methods with
the same name in wxWebSession and wxWebRequest.
 2021-01-11 03:02:25 +01:00
Catalin Raceanu
76167e271b Insert comma for clarity in a message in the sample 
No real changes.
 2021-01-11 02:57:15 +01:00
Vadim Zeitlin
e530016723 Remove unnecessary trailing backslashes from the sample 
Multiline strings don't need backslashes for continuation.
 2021-01-11 02:55:51 +01:00
Vadim Zeitlin
054892f250 Fix wording of wxWebRequestEvent::GetResponseFileName() docs 
Also document that the returned string is the full path and not just the
name of the file.
 2021-01-11 02:54:48 +01:00
Vadim Zeitlin
451b97170b Small tweak to wxCredentialEntryDialog docs consistency 
Don't use the article for just one parameter.
 2021-01-11 02:51:05 +01:00
Vadim Zeitlin
c750661c40 Use explicit encodings in wxWebRequestCURL 
At least in one place the code is still wrong when sending data as HTTP
headers can contain only ASCII characters, but at least do our best to
interpret the data we receive correctly.
 2021-01-11 02:42:09 +01:00
Vadim Zeitlin
df13c2bd26 Properly percent-encode URLs passed to libcurl 
URLs can't contain non-ASCII characters, so use wxURI to encode them
properly.
 2021-01-11 02:31:51 +01:00
Vadim Zeitlin
252373e540 Allow a simple way to rest requesting the given URL in the test 
This does nothing more than just running a GET request for the given
URL for testing purposes.
 2021-01-11 02:30:43 +01:00
Vadim Zeitlin
9149a3725d Assert that we have correct user data in libcurl callbacks 
Don't just silently ignore invalid user data value, this is not supposed
to happen.

Also use "userdata" name for the same parameter of all callbacks
consistently.
 2021-01-11 02:22:38 +01:00
Vadim Zeitlin
397940f5cf Set shut down flag after acquiring the mutex, not before 
As this flag is tested in the worker thread only when it owns the mutex,
set it only after acquiring the mutex too to avoid any possibility of a
data race.
 2021-01-11 01:27:38 +01:00
Vadim Zeitlin
0f82a1e043 Use atomic int for reference count in wxWebRequest classes 
This is required because these classes are copied in both the main and
the worker threads and using plain int is MT-unsafe.
 2021-01-11 01:24:55 +01:00
Vadim Zeitlin
de93f8be5b Fix race condition when setting the request state to active 
Call SetState(State_Active) before signalling the worker thread, as
otherwise it would be possible for it to wake up and set its state to
something else before it was reset to "active" from the main thread.

This fixed another TSAN error.
 2021-01-11 01:15:28 +01:00
Vadim Zeitlin
fd1d396406 Use wxCondition::Signal() rather than Broadcast() 
The latter is unnecessary when there is only one thread to wake up.
 2021-01-11 01:12:06 +01:00
Vadim Zeitlin
1d52f1cbb5 Add a comment explaining mutex use in wxWebSessionCURL 
No real changes.
 2021-01-11 01:11:44 +01:00
Vadim Zeitlin
0588b0e7ce Extract all the wxWebRequest test sections in separate tests 
As in 31a441e814 (Use separate test cases for wxWebRequest auth tests,
2021-01-10), there is no real reason to use sections here as we don't
reuse anything between them and using separate tests makes it easier to
run individual tests and, especially, combinations of them.

This commit is best viewed ignoring whitespace-only changes.
 2021-01-10 21:27:51 +01:00
Vadim Zeitlin
29a36ef4ff Unlock wxWebSessionCURL mutex before destroying it 
Mutexes must not be destroyed while locked and thread sanitizer
correctly complains about this, so ensure that we do unlock the mutex
before the worked thread terminates and the object is destroyed.
 2021-01-10 21:27:15 +01:00