Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary checks in the window ID management code

Browse Source 
Remove asserts from the functions which are called only once and for which the
caller already performs exactly the same check before calling them.
This commit is contained in:
Vadim Zeitlin
2016-02-10 00:10:47 +01:00
parent aece1f81b6
commit f357fcc679
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/common/windowid.cpp
View File

@@ -87,9 +87,6 @@ void UnreserveIdRefCount(wxWindowID winid)
// Get the usage count of an id
int GetIdRefCount(wxWindowID winid)
{
wxCHECK_MSG(winid >= wxID_AUTO_LOWEST && winid <= wxID_AUTO_HIGHEST, 0,
wxT("invalid id range"));
winid -= wxID_AUTO_LOWEST;
int refCount = gs_autoIdsRefCount[winid];
if (refCount == ID_COUNTTOOLARGE)
@@ -100,9 +97,6 @@ int GetIdRefCount(wxWindowID winid)
// Increase the count for an id
void IncIdRefCount(wxWindowID winid)
{
wxCHECK_RET(winid >= wxID_AUTO_LOWEST && winid <= wxID_AUTO_HIGHEST,
wxT("invalid id range"));
winid -= wxID_AUTO_LOWEST;
wxCHECK_RET(gs_autoIdsRefCount[winid] != ID_FREE, wxT("id should first be reserved"));
@@ -133,9 +127,6 @@ void IncIdRefCount(wxWindowID winid)
// Decrease the count for an id
void DecIdRefCount(wxWindowID winid)
{
wxCHECK_RET(winid >= wxID_AUTO_LOWEST && winid <= wxID_AUTO_HIGHEST,
wxT("invalid id range"));
winid -= wxID_AUTO_LOWEST;
wxCHECK_RET(gs_autoIdsRefCount[winid] != ID_FREE, wxT("id count already 0"));