Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Get rid of unnecessary overriding function

Browse Source 
OnValidationFailure() in derived class wxEnumProperty has the same implementation (empty body) as the implementation in the base class wxPGProperty so overriding this function in derived class is not necessary.
This commit is contained in:
Artur Wieczorek
2019-03-09 18:39:13 +01:00
parent 47bba8764a
commit 86af7d5ee9
3 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/wx/propgrid/props.h
View File

@@ -398,8 +398,6 @@ public:
// this take advantage of it. // this take advantage of it.
virtual int GetChoiceSelection() const wxOVERRIDE { return m_index; } virtual int GetChoiceSelection() const wxOVERRIDE { return m_index; }
virtual void OnValidationFailure( wxVariant& pendingValue ) wxOVERRIDE;
protected: protected:
int GetIndex() const; int GetIndex() const;

2
interface/wx/propgrid/props.h
View File

@@ -361,8 +361,6 @@ public:
// this take advantage of it. // this take advantage of it.
virtual int GetChoiceSelection() const; virtual int GetChoiceSelection() const;
virtual void OnValidationFailure( wxVariant& pendingValue );
protected: protected:
int GetIndex() const; int GetIndex() const;

5
src/propgrid/props.cpp
View File

@@ -1434,11 +1434,6 @@ bool wxEnumProperty::ValueFromInt_(wxVariant& value, int* pIndex, int intVal, in
return false; return false;
} }
void
wxEnumProperty::OnValidationFailure( wxVariant& WXUNUSED(pendingValue) )
{
}
void wxEnumProperty::SetIndex( int index ) void wxEnumProperty::SetIndex( int index )
{ {
m_index = index; m_index = index;