From 86af7d5ee9d5f3b694feba96e77837c8ccc48d3b Mon Sep 17 00:00:00 2001 From: Artur Wieczorek Date: Sat, 9 Mar 2019 18:39:13 +0100 Subject: [PATCH] Get rid of unnecessary overriding function OnValidationFailure() in derived class wxEnumProperty has the same implementation (empty body) as the implementation in the base class wxPGProperty so overriding this function in derived class is not necessary. --- include/wx/propgrid/props.h | 2 -- interface/wx/propgrid/props.h | 2 -- src/propgrid/props.cpp | 5 ----- 3 files changed, 9 deletions(-) diff --git a/include/wx/propgrid/props.h b/include/wx/propgrid/props.h index 65299be2d1..358e2891ca 100644 --- a/include/wx/propgrid/props.h +++ b/include/wx/propgrid/props.h @@ -398,8 +398,6 @@ public: // this take advantage of it. virtual int GetChoiceSelection() const wxOVERRIDE { return m_index; } - virtual void OnValidationFailure( wxVariant& pendingValue ) wxOVERRIDE; - protected: int GetIndex() const; diff --git a/interface/wx/propgrid/props.h b/interface/wx/propgrid/props.h index f83b30a3d0..e4be903293 100644 --- a/interface/wx/propgrid/props.h +++ b/interface/wx/propgrid/props.h @@ -361,8 +361,6 @@ public: // this take advantage of it. virtual int GetChoiceSelection() const; - virtual void OnValidationFailure( wxVariant& pendingValue ); - protected: int GetIndex() const; diff --git a/src/propgrid/props.cpp b/src/propgrid/props.cpp index f0b2964315..8957bb5d59 100644 --- a/src/propgrid/props.cpp +++ b/src/propgrid/props.cpp @@ -1434,11 +1434,6 @@ bool wxEnumProperty::ValueFromInt_(wxVariant& value, int* pIndex, int intVal, in return false; } -void -wxEnumProperty::OnValidationFailure( wxVariant& WXUNUSED(pendingValue) ) -{ -} - void wxEnumProperty::SetIndex( int index ) { m_index = index;