Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use wxScopedPtr in wxImage unit test

Browse Source 
Don't manage memory manually, this resulted in error leaks if any checks
failed.
This commit is contained in:
Vadim Zeitlin
2022-04-23 15:35:22 +01:00
parent c4dc0353cc
commit 684dd4a5a6
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/image/image.cpp
View File

@@ -31,6 +31,7 @@
#include "wx/wfstream.h" #include "wx/wfstream.h"
#include "wx/clipbrd.h" #include "wx/clipbrd.h"
#include "wx/dataobj.h" #include "wx/dataobj.h"
#include "wx/scopedptr.h"
#include "testimage.h" #include "testimage.h"
@@ -189,7 +190,7 @@ void ImageTestCase::LoadFromSocketStream()
url.GetError() url.GetError()
); );
wxInputStream *in_stream = url.GetInputStream(); wxScopedPtr<wxInputStream> in_stream(url.GetInputStream());
WX_ASSERT_MESSAGE WX_ASSERT_MESSAGE
( (
("Opening URL \"%s\" failed.", testData[i].url), ("Opening URL \"%s\" failed.", testData[i].url),
@@ -206,8 +207,6 @@ void ImageTestCase::LoadFromSocketStream()
("Loading image from \"%s\" failed.", testData[i].url), ("Loading image from \"%s\" failed.", testData[i].url),
img.LoadFile(*in_stream, testData[i].type) img.LoadFile(*in_stream, testData[i].type)
); );
delete in_stream;
} }
} }