From 684dd4a5a68dc86a0e312366df6c7a83e798e51b Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sat, 23 Apr 2022 15:35:22 +0100 Subject: [PATCH] Use wxScopedPtr in wxImage unit test Don't manage memory manually, this resulted in error leaks if any checks failed. --- tests/image/image.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/image/image.cpp b/tests/image/image.cpp index 5eb923eb34..99a85fa66f 100644 --- a/tests/image/image.cpp +++ b/tests/image/image.cpp @@ -31,6 +31,7 @@ #include "wx/wfstream.h" #include "wx/clipbrd.h" #include "wx/dataobj.h" +#include "wx/scopedptr.h" #include "testimage.h" @@ -189,7 +190,7 @@ void ImageTestCase::LoadFromSocketStream() url.GetError() ); - wxInputStream *in_stream = url.GetInputStream(); + wxScopedPtr in_stream(url.GetInputStream()); WX_ASSERT_MESSAGE ( ("Opening URL \"%s\" failed.", testData[i].url), @@ -206,8 +207,6 @@ void ImageTestCase::LoadFromSocketStream() ("Loading image from \"%s\" failed.", testData[i].url), img.LoadFile(*in_stream, testData[i].type) ); - - delete in_stream; } }