Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Define ~wxMSWOwnerDrawnButtonBase() for all compilers

Browse Source 
There is no reason to only make it protected for gcc and clang, recent
MSVS versions can also give a warning (C5204, which is disabled by
default, but makes sense to enable) otherwise.

Also remove the comment about obsolete gcc 3.4.5.

Closes #19011.

Co-Authored-By: Vadim Zeitlin <vadim@wxwidgets.org>
This commit is contained in:
David Connet
2021-01-27 21:56:28 +01:00
committed by Vadim Zeitlin
parent 2a4c52a414
commit 5061a112a4
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
include/wx/msw/ownerdrawnbutton.h
View File

@@ -37,14 +37,7 @@ protected:
// has virtual functions, but no virtual destructor without making the dtor
// virtual which is not needed here as objects are never deleted via
// pointers to this class (and protected dtor enforces this).
//
// Unfortunately g++ 3.4.5 still complains about the dtor being non virtual
// even if it is protected, but actually does not give any warnings if the
// dtor is not defined at all, so work around this 3.4.5 bug inside our
// general g++ workaround.
#if wxCHECK_GCC_VERSION(4, 0) || defined(__clang__)
~wxMSWOwnerDrawnButtonBase() { }
#endif // g++ 4.0+
// Make the control owner drawn if necessary to implement support for the
// given foreground colour.