Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use switch over enum-valued variable rather than "if"s

Browse Source 
No real changes, just make sure we use an (exhaustive) switch rather
than a less obvious sequence of if statements.
This commit is contained in:
Vadim Zeitlin
2021-01-16 23:33:18 +01:00
parent c41041a3b6
commit 4c19572d9d
1 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/common/webrequest.cpp
View File

@@ -680,19 +680,24 @@ void wxWebResponseImpl::ReportDataReceived(size_t sizeReceived)
m_readBuffer.UngetAppendBuf(sizeReceived);
m_request.ReportDataReceived(sizeReceived);
if ( m_request.GetStorage() == wxWebRequest::Storage_File )
switch ( m_request.GetStorage() )
{
m_file.Write(m_readBuffer.GetData(), m_readBuffer.GetDataLen());
}
else if ( m_request.GetStorage() == wxWebRequest::Storage_None )
{
wxWebRequestEvent evt(wxEVT_WEBREQUEST_DATA, m_request.GetId(), wxWebRequest::State_Active);
evt.SetDataBuffer(m_readBuffer.GetData(), m_readBuffer.GetDataLen());
m_request.GetHandler()->ProcessEvent(evt);
}
case wxWebRequest::Storage_Memory:
// Nothing to do, just keep appending data to the buffer.
break;
if ( m_request.GetStorage() != wxWebRequest::Storage_Memory )
m_readBuffer.Clear();
case wxWebRequest::Storage_File:
m_file.Write(m_readBuffer.GetData(), m_readBuffer.GetDataLen());
m_readBuffer.Clear();
break;
case wxWebRequest::Storage_None:
wxWebRequestEvent evt(wxEVT_WEBREQUEST_DATA, m_request.GetId(), wxWebRequest::State_Active);
evt.SetDataBuffer(m_readBuffer.GetData(), m_readBuffer.GetDataLen());
m_request.GetHandler()->ProcessEvent(evt);
m_readBuffer.Clear();
break;
}
}
wxString wxWebResponseImpl::GetDataFile() const