Merge branch 'fix-caret-default'

Fix using default-constructed wxCaret.

See https://github.com/wxWidgets/wxWidgets/pull/2007

include/wx/caret.h

@@ -153,6 +153,7 @@ protected:
         m_window = window;
         m_width = width;
         m_height = height;
+        DoSize();
 
         return true;
     }

src/generic/caret.cpp

@@ -103,7 +103,8 @@ void wxCaret::InitGeneric()
 #ifndef wxHAS_CARET_USING_OVERLAYS
     m_xOld =
     m_yOld = -1;
-    m_bmpUnderCaret.Create(m_width, m_height);
+    if (m_width && m_height)
+        m_bmpUnderCaret.Create(m_width, m_height);
 #endif
 }
 
@@ -174,7 +175,10 @@ void wxCaret::DoSize()
     m_overlay.Reset();
 #else
     // Change bitmap size
-    m_bmpUnderCaret = wxBitmap(m_width, m_height);
+    if (m_width && m_height)
+        m_bmpUnderCaret = wxBitmap(m_width, m_height);
+    else
+        m_bmpUnderCaret = wxBitmap();
 #endif
     if (countVisible > 0)
     {

tests/controls/windowtest.cpp

@@ -136,10 +136,22 @@ TEST_CASE_METHOD(WindowTestCase, "Window::Mouse", "[window]")
     CHECK(m_window->GetCursor().IsOk());
 
 #if wxUSE_CARET
-    //A plain window doesn't have a caret
     CHECK(!m_window->GetCaret());
 
-    wxCaret* caret = new wxCaret(m_window, 16, 16);
+    wxCaret* caret;
+
+    // Try creating the caret in two different, but normally equivalent, ways.
+    SECTION("Caret 1-step")
+    {
+        caret = new wxCaret(m_window, 16, 16);
+    }
+
+    SECTION("Caret 2-step")
+    {
+        caret = new wxCaret();
+        caret->Create(m_window, 16, 16);
+    }
+
     m_window->SetCaret(caret);
 
     CHECK(m_window->GetCaret()->IsOk());