Amebis/Updater
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix flapping update process

Browse Source 
The m_ok variable was not initialized, and set to true in case of
successful initialization - it depended on pure luck.

Since debug versions usually initialize stack and heap allocated memory
(to 0xCD or something like that), this explains why update check was
failing silently and randomly in release versions.

Signed-off-by: Simon Rozman <simon@rozman.si>
This commit is contained in:
Simon Rozman 2020-02-12 13:18:13 +01:00
parent 51c7ed11c0
commit 349c42fe57
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Updater/src/chkthread.cpp
View File

@ -32,6 +32,7 @@ wxDEFINE_EVENT(wxEVT_UPDATER_CHECK_COMPLETE, wxThreadEvent);
wxUpdCheckThread::wxUpdCheckThread(const wxString &langId, wxEvtHandler *parent) : wxUpdCheckThread::wxUpdCheckThread(const wxString &langId, wxEvtHandler *parent) :
m_parent(parent), m_parent(parent),
m_ok(true),
m_abort(false), m_abort(false),
m_langId(langId), m_langId(langId),
m_config(wxT(PRODUCT_CFG_APPLICATION) wxT("\\Updater"), wxT(PRODUCT_CFG_VENDOR)), m_config(wxT(PRODUCT_CFG_APPLICATION) wxT("\\Updater"), wxT(PRODUCT_CFG_VENDOR)),