From 349c42fe5797baae2161402eeca4bdd4c1108142 Mon Sep 17 00:00:00 2001 From: Simon Rozman Date: Wed, 12 Feb 2020 13:18:13 +0100 Subject: [PATCH] Fix flapping update process The m_ok variable was not initialized, and set to true in case of successful initialization - it depended on pure luck. Since debug versions usually initialize stack and heap allocated memory (to 0xCD or something like that), this explains why update check was failing silently and randomly in release versions. Signed-off-by: Simon Rozman --- Updater/src/chkthread.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Updater/src/chkthread.cpp b/Updater/src/chkthread.cpp index e26b2b3..5320735 100644 --- a/Updater/src/chkthread.cpp +++ b/Updater/src/chkthread.cpp @@ -32,6 +32,7 @@ wxDEFINE_EVENT(wxEVT_UPDATER_CHECK_COMPLETE, wxThreadEvent); wxUpdCheckThread::wxUpdCheckThread(const wxString &langId, wxEvtHandler *parent) : m_parent(parent), + m_ok(true), m_abort(false), m_langId(langId), m_config(wxT(PRODUCT_CFG_APPLICATION) wxT("\\Updater"), wxT(PRODUCT_CFG_VENDOR)),