c63d47bc94
Almost totally rewrite the resize-after-toggle code in this control so that it actually makes sense and works, especially in the situations when the contents of wxCollapsiblePane changes, for example when it contains another wxCollapsiblePane inside it which can be collapsed or expanded. Previously, this didn't work at all in wxGTK and the inner pane always remained at its minimal, collapsed size. Now it does, after doing the following: First, replace the completely useless DoGetBestSize() which just did the same thing as its base class implementation with the code actually determining the best size of the window that was previously hidden inside gtk_collapsiblepane_expanded_callback() for some reason. Note that the comment about "not caching the best size" in the old code was very out of date and was probably left over from the days when GetBestSize() itself was virtual, as caching is not done in DoGetBestSize() anyhow, but in GetBestSize() itself. So, second, do fix the best size invalidation by doing it explicitly whenever the pane is toggled. And, relatedly, do not set the min size of anything because this overrides the layout computations and is never reset/invalidated, unlike the best size, even if the best size of the pane changes, e.g. because of a change to its contents. Finally, remove many thoroughly outdated comments, e.g. the one speaking about OnStateChange() which doesn't exist at all in this implementation.
About
wxWidgets is a free and open source cross-platform C++ framework for writing advanced GUI applications using native controls.
wxWidgets allows you to write native-looking GUI applications for all the major desktop platforms and also helps with abstracting the differences in the non-GUI aspects between them. It is free for the use in both open source and commercial applications, comes with the full, easy to read and modify, source and extensive documentation and a collection of more than a hundred examples. You can learn more about wxWidgets at https://www.wxwidgets.org/ and read its documentation online at http://docs.wxwidgets.org/
Platforms
wxWidgets currently supports the following primary platforms:
- Windows XP, Vista, 7, 8 and 10 (32/64 bits).
- Most Unix variants using the GTK+ toolkit (version 2.6 or newer or 3.x).
- OS X (10.7 or newer) using Cocoa (32/64 bits).
Most popular C++ compilers are supported including but not limited to:
- Microsoft Visual C++ 2003 or later (up to 2017).
- g++ 3.4 or later, including MinGW/MinGW-64/TDM under Windows.
- Clang under OS X and Linux.
- Intel icc compiler.
- Oracle (ex-Sun) aCC.
Licence
wxWidgets licence is a modified version of LGPL explicitly allowing not distributing the sources of an application using the library even in the case of static linking.
Building
For building the library, please see platform-specific documentation under
docs/<port> directory.
If you're building the sources checked out from Git, and not from a released versions, please see these additional Git-specific notes.
Further information
If you are looking for support, you can get it from
- Mailing Lists
- Discussion Forums
- #wxwidgets IRC channel
- Stack Overflow
(tag your questions with
wxwidgets) - Please report bugs at https://trac.wxwidgets.org/newticket
We would also gladly welcome your contributions.
Have fun!
The wxWidgets Team.