Files
wxWidgets/src/common/ctrlsub.cpp
Vadim Zeitlin 8584b0e64b Check index in wxItemContainer methods working with client data.
The test for index validity should be done by the base class public methods
themselves so that the protected methods in the derived classes don't need to
do it because this allows to have the check in one place only and not in every
port-specific derived class and also because a protected method can reasonably
expect to be called with already validated parameters.

This makes it unnecessary to perform the same check in many derived classes
and fixes the problem with those that forgot to check for item validity at all
before (like wxGTK wxChoice).

Also add a unit test checking for the correct behaviour. Unfortunately we
don't have any way to test for the precise assert being triggered so the test
passed for wxGTK wxChoice even before in debug builds because the expected
assert was raised by wxArray::Item() but the code crashed in release build --
whereas now it doesn't any more.

Closes #12858.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@66664 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2011-01-10 12:00:54 +00:00

296 lines
7.8 KiB
C++

///////////////////////////////////////////////////////////////////////////////
// Name: src/common/ctrlsub.cpp
// Purpose: wxItemContainer implementation
// Author: Vadim Zeitlin
// Modified by:
// Created: 22.10.99
// RCS-ID: $Id$
// Copyright: (c) wxWidgets team
// Licence: wxWindows licence
///////////////////////////////////////////////////////////////////////////////
// ============================================================================
// declarations
// ============================================================================
// ----------------------------------------------------------------------------
// headers
// ----------------------------------------------------------------------------
// For compilers that support precompilation, includes "wx.h".
#include "wx/wxprec.h"
#ifdef __BORLANDC__
#pragma hdrstop
#endif
#if wxUSE_CONTROLS
#ifndef WX_PRECOMP
#include "wx/ctrlsub.h"
#include "wx/arrstr.h"
#endif
IMPLEMENT_ABSTRACT_CLASS(wxControlWithItems, wxControl)
// ============================================================================
// wxItemContainerImmutable implementation
// ============================================================================
wxItemContainerImmutable::~wxItemContainerImmutable()
{
// this destructor is required for Darwin
}
// ----------------------------------------------------------------------------
// selection
// ----------------------------------------------------------------------------
wxString wxItemContainerImmutable::GetStringSelection() const
{
wxString s;
int sel = GetSelection();
if ( sel != wxNOT_FOUND )
s = GetString((unsigned int)sel);
return s;
}
bool wxItemContainerImmutable::SetStringSelection(const wxString& s)
{
const int sel = FindString(s);
if ( sel == wxNOT_FOUND )
return false;
SetSelection(sel);
return true;
}
wxArrayString wxItemContainerImmutable::GetStrings() const
{
wxArrayString result;
const unsigned int count = GetCount();
result.Alloc(count);
for ( unsigned int n = 0; n < count; n++ )
result.Add(GetString(n));
return result;
}
// ============================================================================
// wxItemContainer implementation
// ============================================================================
wxItemContainer::~wxItemContainer()
{
// this destructor is required for Darwin
}
// ----------------------------------------------------------------------------
// deleting items
// ----------------------------------------------------------------------------
void wxItemContainer::Clear()
{
if ( HasClientObjectData() )
{
const unsigned count = GetCount();
for ( unsigned i = 0; i < count; ++i )
ResetItemClientObject(i);
}
SetClientDataType(wxClientData_None);
DoClear();
}
void wxItemContainer::Delete(unsigned int pos)
{
wxCHECK_RET( pos < GetCount(), wxT("invalid index") );
if ( HasClientObjectData() )
ResetItemClientObject(pos);
DoDeleteOneItem(pos);
if ( IsEmpty() )
{
SetClientDataType(wxClientData_None);
}
}
// ----------------------------------------------------------------------------
//
// ----------------------------------------------------------------------------
int wxItemContainer::DoInsertItemsInLoop(const wxArrayStringsAdapter& items,
unsigned int pos,
void **clientData,
wxClientDataType type)
{
int n = wxNOT_FOUND;
const unsigned int count = items.GetCount();
for ( unsigned int i = 0; i < count; ++i )
{
n = DoInsertOneItem(items[i], pos++);
if ( n == wxNOT_FOUND )
break;
AssignNewItemClientData(n, clientData, i, type);
}
return n;
}
int
wxItemContainer::DoInsertOneItem(const wxString& WXUNUSED(item),
unsigned int WXUNUSED(pos))
{
wxFAIL_MSG( wxT("Must be overridden if DoInsertItemsInLoop() is used") );
return wxNOT_FOUND;
}
// ----------------------------------------------------------------------------
// client data
// ----------------------------------------------------------------------------
void wxItemContainer::SetClientObject(unsigned int n, wxClientData *data)
{
wxASSERT_MSG( !HasClientUntypedData(),
wxT("can't have both object and void client data") );
wxCHECK_RET( IsValid(n), "Invalid index passed to SetClientObject()" );
if ( HasClientObjectData() )
{
wxClientData * clientDataOld
= static_cast<wxClientData *>(DoGetItemClientData(n));
if ( clientDataOld )
delete clientDataOld;
}
else // didn't have any client data so far
{
// now we have object client data
DoInitItemClientData();
SetClientDataType(wxClientData_Object);
}
DoSetItemClientData(n, data);
}
wxClientData *wxItemContainer::GetClientObject(unsigned int n) const
{
wxCHECK_MSG( HasClientObjectData(), NULL,
wxT("this window doesn't have object client data") );
wxCHECK_MSG( IsValid(n), NULL,
"Invalid index passed to GetClientObject()" );
return static_cast<wxClientData *>(DoGetItemClientData(n));
}
wxClientData *wxItemContainer::DetachClientObject(unsigned int n)
{
wxClientData * const data = GetClientObject(n);
if ( data )
{
// reset the pointer as we don't own it any more
DoSetItemClientData(n, NULL);
}
return data;
}
void wxItemContainer::SetClientData(unsigned int n, void *data)
{
if ( !HasClientData() )
{
DoInitItemClientData();
SetClientDataType(wxClientData_Void);
}
wxASSERT_MSG( HasClientUntypedData(),
wxT("can't have both object and void client data") );
wxCHECK_RET( IsValid(n), "Invalid index passed to SetClientData()" );
DoSetItemClientData(n, data);
}
void *wxItemContainer::GetClientData(unsigned int n) const
{
wxCHECK_MSG( HasClientUntypedData(), NULL,
wxT("this window doesn't have void client data") );
wxCHECK_MSG( IsValid(n), NULL,
"Invalid index passed to GetClientData()" );
return DoGetItemClientData(n);
}
void wxItemContainer::AssignNewItemClientData(unsigned int pos,
void **clientData,
unsigned int n,
wxClientDataType type)
{
switch ( type )
{
case wxClientData_Object:
SetClientObject
(
pos,
(reinterpret_cast<wxClientData **>(clientData))[n]
);
break;
case wxClientData_Void:
SetClientData(pos, clientData[n]);
break;
default:
wxFAIL_MSG( wxT("unknown client data type") );
// fall through
case wxClientData_None:
// nothing to do
break;
}
}
void wxItemContainer::ResetItemClientObject(unsigned int n)
{
wxClientData * const data = GetClientObject(n);
if ( data )
{
delete data;
DoSetItemClientData(n, NULL);
}
}
// ============================================================================
// wxControlWithItems implementation
// ============================================================================
void
wxControlWithItemsBase::InitCommandEventWithItems(wxCommandEvent& event, int n)
{
InitCommandEvent(event);
if ( n != wxNOT_FOUND )
{
if ( HasClientObjectData() )
event.SetClientObject(GetClientObject(n));
else if ( HasClientUntypedData() )
event.SetClientData(GetClientData(n));
}
}
#endif // wxUSE_CONTROLS