Commit Graph

629 Commits

Author SHA1 Message Date
Vadim Zeitlin
5276b0a53c Use wxDELETE() and wxDELETEA() when possible.
Use wxDELETE[A]() functions which automatically NULL out their arguments after
deleting them instead of doing it manually.

Closes #9685.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64656 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-06-20 18:18:23 +00:00
Vadim Zeitlin
e612dec202 Assert if an invalid column index is specified when inserting wxListCtrl item.
This also catches the case of inserting an item in a report mode wxListCtrl
without adding any columns to it first. Previously this did result in an
assert but with a less clear error message and, most importantly, still a
crash afterwards. Assert only now, don't crash.

The message could still be improved but hopefully people will be able to
understand that inserting items when no columns are defined is not the right
thing to do.

Closes #12119.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64473 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-06-03 10:35:41 +00:00
Vadim Zeitlin
b6812a6f19 Add column parameter to wxListCtrl::GetItemText().
Allow retrieving the text from columns other than the first one directly.

Add implementations for MSW and generic versions, documentation and a unit
test.

Closes #11597.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64281 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-05-10 21:22:16 +00:00
Vadim Zeitlin
6578236183 Fix over aggressive clipping in generic wxListCtrl header drawing.
Clipping out 4 pixels vertically resulted in truncating any letters with
descent (e.g. "g" or "q") under OS X where the native header size is just tall
enough to show the text.

Simply don't clip that much but use the entire header width.

Closes #11780.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63947 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-04-12 00:37:13 +00:00
Vadim Zeitlin
476de5ea9a Fix crash in wxListbook if image list is assigned after adding pages.
The generic wxListCtrl didn't properly support switching between report and
non-report modes without invalidating the control contents, the required in
non report view geometry info pointers were not allocated when the control was
switched to a, say, list mode and not created in it.

Fix this by updating all list control lines when the report mode changes.

Closes #11698.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63946 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-04-12 00:37:08 +00:00
Stefan Csomor
7eb8aeb8b1 using statically allocated font objects for speedup
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63917 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-04-08 18:47:41 +00:00
Vadim Zeitlin
5d12911287 Revert unneeded fix for list control headers from r63177.
The call to SetItemMinSize() shouldn't be needed and the latest OS X version
does work correctly without it. Apparently the real bug was fixed somewhere
else in the meanwhile.

Closes #11309.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63662 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-03-12 09:36:37 +00:00
Vadim Zeitlin
c1fae0d0ee Don't store header height in generic wxListCtrl member variable.
This is simply unnecessary and resulted in a crash in wxDFB because the window
was used for this variable initialization before being created.

Closes #11711.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63638 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-03-06 00:31:04 +00:00
Vadim Zeitlin
1bab36277c Fix toggling the header in the generic wxListCtrl.
We need to update the lfags first before deciding whether we should create or
destroy the header.

Also add a test for toggling the header to the listctrl sample.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63637 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-03-06 00:31:00 +00:00
Stefan Csomor
237077b501 applying patch, closes #11309
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63177 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-01-18 09:03:05 +00:00
Stefan Csomor
0a84f928e9 moving themeing include to private.h
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@61987 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-09-21 12:57:12 +00:00
Vadim Zeitlin
b3b17ee743 Fix recurring typo in "theming".
It was (consistently) misspelt as "themeing" in several places.

Closes #11206.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@61962 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-09-18 16:16:30 +00:00
Vadim Zeitlin
9a83f86094 Globally replace _T() with wxT().
Standardize on using a single macro across all wxWidgets sources and solve the name clash with Sun CC standard headers (see #10660).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@61508 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-07-23 20:30:22 +00:00
Vadim Zeitlin
e1983cad7c implement Update() properly for the generic wxListCtrl (see #10857)
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@60824 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-05-30 22:25:42 +00:00
Vadim Zeitlin
b18e2046af pass wxIntPtr, not wxUIntPtr, to wxListCtrl::SortItems() callback as it's more compatible with the existing code assuming that this parameter is signed (as our own wxFileCtrl did)
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@60198 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-04-16 13:00:40 +00:00
Vadim Zeitlin
6e2f308461 use wxUIntPtr instead of long for 3rd parameter of wxListCtrl::SortItems() to allow passing pointers to it
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@60182 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-04-15 21:23:50 +00:00
Stefan Csomor
f1c40652a0 reworked font handling for osx
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@59644 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-03-20 13:56:57 +00:00
Paul Cornett
fd1dc2a7e6 fix event table base for wxListMainWindow
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@59075 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-02-21 20:30:57 +00:00
Francesco Montorsi
977a41ec3e use YieldFor() in wxTopLevelWindowGTK::RequestUserAttention; comment on the use of YieldFor() in wxProgressDialog; add some TODOs near wxYieldIfNeeded()/wxSafeYield() calls in wxListCtrl, wxDataViewCtrl, wxTreeCtrl (closes #10320)
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58916 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-02-15 15:42:15 +00:00
Vadim Zeitlin
5d55031c21 compilation fixes for wxMSW/Univ
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58645 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-02-04 10:07:58 +00:00
Francesco Montorsi
64894596ea fix a typo in comment
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58589 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-02-01 12:06:15 +00:00
Robert Roebling
edea2c4af5 Fixes #10443: wxListCtrl::MoveToItem
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58479 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-28 10:24:14 +00:00
Robert Roebling
e5d28ed426 Fix for GetScrollPos() assert
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58459 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-27 15:35:34 +00:00
Francesco Montorsi
74491934c6 fix PCH builds
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58454 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-27 12:33:16 +00:00
Francesco Montorsi
52d2a5e454 fix crash when calling InsertColumn() on a wxListCtrl with wxLC_NO_HEADER style
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58453 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-27 12:05:27 +00:00
Francesco Montorsi
ad48602087 small cleanup; move private class definitions in a private header
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58452 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-27 12:01:54 +00:00
Robert Roebling
32fc355f09 Finally corrected drawing of wxListCtrl selection rect for GTK+
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58415 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-25 20:22:37 +00:00
Vadim Zeitlin
21f673955a removed debugging wxPrintf() which not only had nothing to do there but also broke PCH-less compilation
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58376 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-25 11:06:31 +00:00
Stefan Csomor
64374d1b06 bring in the definition of wxSizer, making non-precomp builds working again after r58312
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58358 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-24 18:07:46 +00:00
Francesco Montorsi
7d7b3f69f2 do not export private symbols in wx shared libraries
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58351 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-24 13:40:46 +00:00
Robert Roebling
dff750b48f Always use theme border for inner window under wxGTK
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58333 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-23 15:10:09 +00:00
Robert Roebling
43cb7161a0 GTK+'s native controls usually have a bigger line height
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58324 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-23 11:55:45 +00:00
Robert Roebling
8be0b88848 Restore keyboard navi
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58323 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-23 11:51:52 +00:00
Robert Roebling
06cd40a8b9 Reorganized wxListCtrl's window layout (same as wxDataViewCtrl), call RecalculatePositions() from OnPaint() to get rid of flicker
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58312 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-22 23:01:14 +00:00
Vadim Zeitlin
d3b9f782ef don't use annoying and unneeded in C++ casts of NULL to "T *" in all other files neither
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58227 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-19 13:55:27 +00:00
Stefan Csomor
7ac5e1c908 adding 10.4 build compatibility for osx cocoa, see #10361
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58058 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-01-12 20:14:39 +00:00
Vadim Zeitlin
9f2968ad0b make colours used by list and tree controls more consistent with the system theme settings; also use the correct colour for the status bar (closes #10089)
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@57542 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-12-25 13:03:24 +00:00
Vadim Zeitlin
040745d7fc don't use deprecated OnScroll()
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@57539 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-12-25 12:38:58 +00:00
Robin Dunn
5ac526c40c Assert that a mode style *is* set, not that one isn't set.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@56381 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-10-16 22:37:58 +00:00
Francesco Montorsi
c615d6491f Act as wxMSW and make an assert fail, if the user forgot to give a "type flag" (previously it assumed wxLC_LIST type flag).
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@56230 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-10-11 15:54:14 +00:00
Stefan Csomor
569bb120c4 conditionals for carbon only osx code
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@55535 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-09-10 20:26:27 +00:00
Stefan Csomor
530a427a4c adaptions to new osx ouside the main trees
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@55420 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-09-02 17:00:30 +00:00
Vadim Zeitlin
4a5ed5bfc1 paint the space remaining after the columns too in wxListHeaderWindow::OnPaint() (#9855)
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@55117 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-08-18 12:02:01 +00:00
Robin Dunn
78806f0c41 Use WXUNUSED and give more explaination for the handler
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@55056 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-08-10 20:54:35 +00:00
Robin Dunn
c2cbae6bb8 Avoid default child window focus behavior in generic wxListCtrl. Fixes #9563
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@55043 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-08-10 00:26:53 +00:00
Vadim Zeitlin
ebf82d2b4b fix view rectangle calculation for the control with scrollbars (#9467)
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@54957 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-08-03 12:15:30 +00:00
Stefan Csomor
96f04e1df6 OSX regrouping
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@54815 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-07-29 19:50:14 +00:00
Vadim Zeitlin
101198ba0c set wxKeyEvent::m_uniChar correctly in the events generated by generic wxListCtrl (#4581)
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@54608 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-07-13 18:16:38 +00:00
Vadim Zeitlin
b8e57034a2 don't assert when GetSubItemRect() is called in non-report view if it's called with wxLIST_GETSUBITEMRECT_WHOLEITEM
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@54604 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-07-13 17:52:52 +00:00
Vadim Zeitlin
e974c5d258 implement wxListCtrl::GetSubItemRect() for generic version and fix bug in it in wxMSW one; also added a test for it in the sample
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@54437 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-06-30 18:21:33 +00:00