Commit Graph

70636 Commits

Author SHA1 Message Date
Graham Dawes
db15e99884 Fix wxBitmap::GetRawData() in wxQt
This method used to return a dangling pointer to a temporary buffer,
which resulted in a crash when using it, e.g. in the unit test.

Fix this by keeping a QImage as a member in wxBitmapRefData, so that the
pointer to its data remain valid until UngetRawData() is called.

Also check that GetRawData() returns a non-null pointer in the test.

Closes https://github.com/wxWidgets/wxWidgets/pull/1067
2018-12-13 15:24:54 +01:00
Vadim Zeitlin
013c6a6b6a Speed up inserting many items in sorted wxChoice in wxQt
Only sort the combobox once instead of doing it for every item.

See https://github.com/wxWidgets/wxWidgets/pull/1054
2018-12-13 15:17:18 +01:00
chris2oph
89e4ee1ec0 Ensure items are sorted when added to wxChoice in wxQt
Call sort() to resort the model after inserting a new item.

Closes https://github.com/wxWidgets/wxWidgets/pull/1054
2018-12-13 15:10:59 +01:00
Vadim Zeitlin
5189781072 Move wxDataViewCtrl incompatibility note to the correct section
3a24beca62 added this in a wrong place, as
this change does not result in any build errors.

See #18295.
2018-12-13 15:09:13 +01:00
Vadim Zeitlin
b9fe8ca10c Try to use pkg-config for detecting libtiff in configure
This is more reliable than checking whether we can link with the library
manually and may work even if it's installed in a non-standard location.

It also allows the user to specify PKG_CONFIG_PATH='pkg-config --static'
when running configure to link with all transitional dependencies when
linking statically.

Closes https://github.com/wxWidgets/wxWidgets/pull/1073

See #18293.
2018-12-13 03:53:44 +01:00
Vadim Zeitlin
c95f668b21 Fix use of dangling pointer in ButtonTestCase::Disabled()
Fix the test added in dfec7aa0c0 which
deleted the button pointer used by EventCounter by simply moving
EventCounter initialization after the button re-creation.

See #16385.
2018-12-13 00:39:25 +01:00
Vadim Zeitlin
141f0cb0e4 Suppress harmless gcc missing initializers warnings in a test
Suppressing the warnings is ugly but less ugly than explicitly
specifying all the omitted elements in the array.
2018-12-12 23:45:09 +01:00
Maarten Bent
c1013d9bfc CMake: Add more option validity checks 2018-12-12 21:28:01 +01:00
Maarten Bent
5348b4fa3b CMake: Improve layout of third party libraries summary
Add more external libraries to the summary, like configure does.
2018-12-12 21:28:00 +01:00
Maarten Bent
91b6305dcd CMake: Improve checking for external libraries
Do not abort when libLZMA or libSecret can not be found, just show a warning.
Do not search for libSecret on macOS.
Disable libraries internally (not in cache) when not searching for them.
2018-12-12 21:28:00 +01:00
Maarten Bent
042b17512e CMake: Check for libSDL only on Unix 2018-12-12 21:28:00 +01:00
Maarten Bent
b9d31dffc5 CMake: Improve finding Iconv
Continue when Iconv can not be found.
Silence warnings when testing if second argument for iconv() is const.
Use correct include dir.
2018-12-12 21:27:57 +01:00
Maarten Bent
14570b4fa3 CMake: Find more external libraries
Check for LibNotify, MSpack, XTest and GnomeVFS2.
2018-12-12 21:27:56 +01:00
Maarten Bent
79344fc5b6 CMake: Fix locale_t type check
Test failed when xlocale.h did not exist.
2018-12-12 20:28:41 +01:00
Maarten Bent
0665db6c1d CMake: Fix html zip sample dependency check 2018-12-12 20:28:41 +01:00
Maarten Bent
981555b788 CMake: Do not add -pthread to link flags with clang on Windows
It causes argument unused warnings.
2018-12-12 20:28:41 +01:00
Maarten Bent
9f21af693c CMake: Install wxrc on all platforms, closes #18289 2018-12-12 20:28:40 +01:00
Vadim Zeitlin
cf25bbbf9a Merge branch 'window-create-disabled'
Make calling wxWindow::Disable() before wxWindow::Create() work.

See https://github.com/wxWidgets/wxWidgets/pull/1071

Closes #16385.
2018-12-12 18:24:10 +01:00
Graham Dawes
ac55d06bc1 Fix a crash when setting a menu icon to a null bitmap in wxQt
Previous implementation didn't take into account that
wxBitmap::GetHandle() could return NULL for wxQt. Specifically when
wxBitmap::IsNull returns true.

Closes https://github.com/wxWidgets/wxWidgets/pull/1071
2018-12-12 18:14:45 +01:00
Graham Dawes
331dc1fdfe Change wxFont::GetEncoding to return UTF8 for wxQt
QT doesn't have the concept of font encoding and is generally Unicode
aware throughout. The previous implementation of wxFont::GetEncoding for
wxQT returned a nonsensical value.

Closes https://github.com/wxWidgets/wxWidgets/pull/1070
2018-12-12 18:13:54 +01:00
Graham Dawes
6c5c9e578b wxCarioContext:Flush now draws back to the QT image
wxCairoContext::Flush was flushing back to the internal image but this
image wasn't drawn back to the QPainter until the wxCarioContext
instance was destroyed.

This fix ensure that after a call to Flush, anything drawn by Cario is
drawn back to the QImage.

Closes https://github.com/wxWidgets/wxWidgets/pull/1068
2018-12-12 18:12:36 +01:00
Vadim Zeitlin
3a24beca62 Document that wxDataViewCtrl now always expands its last column
This has been changed back in 4156e1a5c9
and is a (mildly) incompatible change, so document it in the appropriate
change log section.

See #18295.
2018-12-12 18:01:41 +01:00
Liam Treacy
e7260cffe0 Fix wxRadioBox::Show() behaviour in wxQt
If a QGroupBox is not visible, then you cannot set any of items to be
visible. Update the implementation to match that expected by wx.

Closes https://github.com/wxWidgets/wxWidgets/pull/1065
2018-12-12 03:23:24 +01:00
Liam Treacy
418a1b747e Select first item of wxRadioBox by default in wxQt too
Follow the other ports and select the first radio box item when it's
created, to ensure that it always has selection.

See https://github.com/wxWidgets/wxWidgets/pull/1065
2018-12-12 03:21:17 +01:00
Tobias Taschner
68cbd54db0 Update since version 2018-12-10 21:09:47 +01:00
Liam Treacy
2a64b65149 Fix enabling radiobox buttons in wxQt
If a QGroupBox is disabled, then you cannot set any of its items to be
enabled without first enabling it. Enabling/disabling it will set that
value (true/false) on all of its items, although setting the QGroupBox
to an enabled state which it already has does not result in this
behaviour.

Fix wxQt to match the expected wxRadioBox behaviour and allow the unit
test to pass.

Closes https://github.com/wxWidgets/wxWidgets/pull/1064
2018-12-10 19:52:22 +01:00
Liam Treacy
91a87e765b Don't omit "int" in wxQt wxRadioBox::GetCount() signature
No real changes, just use "unsigned int" instead of just "unsigned".

See https://github.com/wxWidgets/wxWidgets/pull/1064
2018-12-10 19:51:52 +01:00
Stefan Ziegler
0c2956be09 Fix wxInfoBar close button size in high DPI
Don't apply the scaling factor twice when dynamically creating the close
button bitmap.

Closes https://github.com/wxWidgets/wxWidgets/pull/1063

Closes #18283.
2018-12-10 19:48:04 +01:00
Tobias Taschner
85c6fee7cf Add support for libcurl before version 7.28.0
Support older versions might be useful for older
linux distributions and could be used as a
possible fallback to macOS URLSession implementation
on macOS 10.7 and 10.8.
2018-12-10 19:38:17 +01:00
Tobias Taschner
5077eaee6c Expand button sizer in webrequest sample 2018-12-10 19:38:16 +01:00
Tobias Taschner
37df063a26 Implement POST requests with NSURLSession 2018-12-10 19:38:15 +01:00
Tobias Taschner
d477aade96 Use different method to get NSData bytes 2018-12-10 19:38:14 +01:00
Tobias Taschner
152e160f76 Initial NSURLSession implementation
First incomplete implementation based on NSURLSession
2018-12-10 19:38:13 +01:00
Tobias Taschner
45f006d752 Add wxWebSession::GetLibraryVersionInfo() 2018-12-10 19:38:12 +01:00
Tobias Taschner
4af4dd6cbf Init image handlers webrequest sample 2018-12-10 19:38:11 +01:00
Tobias Taschner
725e917ce8 Add webrequest sample to configure 2018-12-10 19:38:10 +01:00
Tobias Taschner
95264069ee Change creation order of mutex and condition 2018-12-10 19:38:09 +01:00
Tobias Taschner
d2420a064c Implement wxWebRequestCURL::Cancel() 2018-12-10 19:38:08 +01:00
Tobias Taschner
fe4a5343f7 Implement wxWebRequestCURL::GetBytesSent 2018-12-10 19:38:08 +01:00
Tobias Taschner
127b596ada Initial libcurl wxWebRequest implementation 2018-12-10 19:38:07 +01:00
Tobias Taschner
2fa38b1d26 Remove incompatible Storage:: specifier 2018-12-10 19:38:06 +01:00
Tobias Taschner
7577c95aab Destroy default wxWebSession in module 2018-12-10 19:38:05 +01:00
Tobias Taschner
f04094e4ec Implement GetBytesReceived() in base class 2018-12-10 19:38:04 +01:00
Tobias Taschner
ab544da1d2 Move GetBytesExpectedToReceive() impl to base class 2018-12-10 19:38:03 +01:00
Cătălin Răceanu
2f4be7e1ae Update src/common/webrequest.cpp
Co-Authored-By: TcT2k <TcT2k@users.noreply.github.com>
2018-12-10 19:38:02 +01:00
Cătălin Răceanu
58ad18adf3 Update samples/webrequest/webrequest.cpp
Co-Authored-By: TcT2k <TcT2k@users.noreply.github.com>
2018-12-10 19:38:01 +01:00
Cătălin Răceanu
0051bbd605 Update interface/wx/webrequest.h
Co-Authored-By: TcT2k <TcT2k@users.noreply.github.com>
2018-12-10 19:38:00 +01:00
Cătălin Răceanu
09bc378aad Update interface/wx/creddlg.h
Co-Authored-By: TcT2k <TcT2k@users.noreply.github.com>
2018-12-10 19:37:59 +01:00
Cătălin Răceanu
7a5916175d Update docs/doxygen/overviews/commondialogs.h 2018-12-10 19:37:58 +01:00
Tobias Taschner
00623291ac Use Content-Disposition in GetSuggestedFileName() 2018-12-10 19:37:56 +01:00