Commit Graph

68978 Commits

Author SHA1 Message Date
Vadim Zeitlin
0d7ab26e7d Factor out wxGenericTreeCtrl::InitVisualAttributes()
No real changes, just avoid calling an event handler directly.
2020-07-14 15:46:05 +02:00
Vadim Zeitlin
1ec7ae9a6f Use wxBrush objects instead of pointers in wxGenericTreeCtrl
There is no need for double indirection, wxBrush object is already
pointer-like internally.

No real changes, just simplify/optimize the code a little.
2020-07-14 15:43:23 +02:00
Ian McInerney
b256aa6956 Replace wxEVT_GRID_HIDE_EDITOR usage with CallAfter
This simplifies the code by removing the need for a special event,
and also means the combox popup handler is no longer needed to reset
the inSetFocus flag for the closing handler.
2020-07-14 12:28:13 +01:00
Artur Wieczorek
cde033df8d Save initial wxPropertyGridManager extra style
Extra style bits used while initializing wxPropertyGridManager are
not saved and therefore cannot be returned by GetExtraStyle(). We need
to save them in a standard way to make them accessible for this function.

See #18813.
2020-07-14 12:21:35 +02:00
Paul Cornett
5325ccfda6 Update generic wxTreeCtrl appearance when theme changes
See #18823
2020-07-13 20:26:59 -07:00
Hertatijanto Hartono
f1f27bc37c Checks for 3rdparty libraries availability in configure
Abort configure run with an error if a 3rd party library doesn't seem to
be present, when it's supposed to be used during the build, as this is
better than postponing the error until make runs into it much later and
also allows us to give a hopefully helpful message telling people that
they might be missing the relevant submodules.

Also add --disable-tests configure option to allow skipping building
tests entirely. In particular, this allows to avoid cloning any
submodules at all when using system libraries on a Unix system.

Closes https://github.com/wxWidgets/wxWidgets/pull/1954
2020-07-13 23:36:31 +02:00
Vadim Zeitlin
3ec166f960 Merge branch 'dos_BuildTools' of https://github.com/doscott/wxWidgets
Official build/packaging scripts fixes: specify TARGET_CPU explicitly
for 32 bit builds (and also document it); don't bother modifying
wxwidgets.props as it now works out of the box.

See https://github.com/wxWidgets/wxWidgets/pull/1960
2020-07-13 20:54:27 +02:00
Vadim Zeitlin
6eab84e26d Use wxSYS_COLOUR_GRAYTEXT for disabled AUI buttons labels
This is more appropriate than wxSYS_COLOUR_INACTIVECAPTIONTEXT which
just happened to be the same as wxSYS_COLOUR_GRAYTEXT under Mac, but
this is not true elsewhere.
2020-07-13 20:24:57 +02:00
dos
5ed09da80c Copy wxwidgets.props to root of *Dev.7z packages; use full source path with fciv command. 2020-07-13 13:34:02 -03:00
dos
050df54930 Add TARGET_CPU=X86 to 32 bit builds. 2020-07-13 13:32:24 -03:00
dos
db01789373 Add TARGET_CPU requirement for x86 DLL build. 2020-07-13 13:28:53 -03:00
mimi89999
87d2f35f37 Change AUI pane top and left colors to wxSYS_COLOUR_WINDOW
Closes #18820
2020-07-13 18:20:26 +02:00
Vadim Zeitlin
96bac38274 Fix spelling mistakes found by codespell 2020-07-13 17:38:47 +02:00
Vadim Zeitlin
0744cd14a1 Try using Python 3 for codespell
Running it using Python 2 seems to result in a problem with not matching
an exclusion line with non-ASCII character, which works fine with Python
3 locally.
2020-07-13 17:38:01 +02:00
Vadim Zeitlin
77e1e6330b Run codespell from where it is installed by pip
And disable the (useful) warning about this directory not being in PATH.
2020-07-13 17:35:30 +02:00
Vadim Zeitlin
d432b1a685 Try installing codespell 1.17.1 via pip
The 1.16 version available in Ubuntu 20.04 doesn't work nearly as well
as the latest one.
2020-07-13 17:30:47 +02:00
Vadim Zeitlin
1fcdaa7f22 Combine all values of codespell --skip option into one
codespell 1.17.1 from Debian Sid accepts multiple -S options, but 1.16
in Ubuntu 20.04 doesn't seem to like them.
2020-07-13 17:25:18 +02:00
Vadim Zeitlin
e4a826d250 Add GitHub workflow checking spelling for headers and docs
Run codespell using GitHub Actions to flag any new spelling errors.
2020-07-13 17:19:26 +02:00
Vadim Zeitlin
77095c5fbd Remove the now unused DISABLED_TEXT_COLOR constant
The previous commit removes all references to this hardcoded colour.
2020-07-13 16:01:05 +02:00
Daniel Kulp
01e9bd008d Use previously Mac-specific colours for all platforms in wxAUI
Get rid of platform checks in wxAUI and use (the same) system colours
everywhere.
2020-07-13 15:59:46 +02:00
Daniel Kulp
623c116b7a Honour the colour alpha channel in wxAuiBitmapFromBits()
This fixes creating wrong bitmaps for system colours with alpha and
allows to use the correct wxSYS_COLOUR_INACTIVECAPTIONTEXT constant
in wxAuiGenericTabArt instead of a wrong but, due to the loss of alpha,
better looking wxSYS_COLOUR_INACTIVECAPTION which was used before.
2020-07-13 15:57:59 +02:00
Vadim Zeitlin
69e27acf0d Merge branch 'im/clipboard' of https://github.com/imciner2/wxWidgets
Ensure the clipboard contents are stored properly on GTK.

See https://github.com/wxWidgets/wxWidgets/pull/1953
2020-07-13 15:33:58 +02:00
Vadim Zeitlin
325648136c Fix system colours in wxGTK wxSysColourChangedEvent handlers
Using wxSystemSettings::GetColour() in wxSysColourChangedEvent handler
in wxGTK could return the old colour value, before the change, because
the callback for notify::gtk-theme-name signal defined in wxTLW, which
generates wxSysColourChangedEvent, could be invoked before the callback
for the same signal in wxSystemSettings, which invalidated its cache.

Fix this by registering the former using g_signal_connect_after() and
thus ensuring that wxSystemSettings callback runs before it, and the
cache is cleared before wxSysColourChangedEvent handlers can use it.

Closes #18818.
2020-07-13 14:23:42 +02:00
Stefan Csomor
f9618ebe5b Revert "disable this test when no wxMenuBar is present"
This reverts commit 769881a45b.
2020-07-13 11:24:16 +02:00
Stefan Csomor
769881a45b disable this test when no wxMenuBar is present
it just is full of calls to menubars ..
2020-07-13 11:19:52 +02:00
Vadim Zeitlin
1eccf833f9 Add codespell line suppression file
This file is used with "-x misc/suppressions/codespell-lines" codespell
option and allows to ignore entire lines, instead of ignoring words that
only occur once or twice and shouldn't be ignored globally because they
could well be misspelt elsewhere.

The remaining words in codespell.ignore occur too many times (as
parameter names in various places) to be ignored in this way.
2020-07-13 02:28:38 +02:00
Vadim Zeitlin
ebc418a02a Move codespell ignore file to new misc/suppressions directory
This is not really a script, so having it under misc/scripts was not
very logical.

Also rename it to explicitly indicate that this file contains the words
to ignore as the next commit will also add another file ignoring the
whole lines.
2020-07-13 02:28:38 +02:00
Daniel Kulp
872692132a Use more appropriate colours for AUI dock art under Mac
Use system colours instead of hard-coding white.

This is still not ideal because ideally the same wxSYS_COLOUR_XXX
constants should be usable under all platforms, but better than just
using completely wrong colours when using dark mode under Mac.
2020-07-13 01:50:21 +02:00
Daniel Kulp
a829b1df06 Simplify bitmap initialization in wxAuiDefaultDockArt
Reduce the number of __WXMAC__ checks by using helper wxColour variables
which have different values under Mac and non-Mac.

No real changes.
2020-07-13 01:50:21 +02:00
Daniel Kulp
f3d4f01513 Improve dark mode test in wxAuiGenericTabArt
Use wxSystemSettings for this instead of manually checking the base
colour components which is both more verbose/difficult and less
reliable.
2020-07-13 01:50:21 +02:00
Daniel Kulp
3d33fcdba8 Adapt the gradient used in AUI tab art in dark mode
Invert its direction and make it darker for better fit.
2020-07-13 01:49:51 +02:00
Daniel Kulp
e12a9b11e4 Update AUI art colours after system colours change
Move code initializing colours and colour-dependent bitmaps from ctor to
UpdateColoursFromSystem(), which means that now this is done not only
once, when creating the object, but also later if the system colours
change (e.g. due to turning on or off the dark mode).
2020-07-13 00:54:02 +02:00
Daniel Kulp
88928e712a Use system colours in wxAuiGenericTabArt
Don't hardcode black and grey, which don't look right in all themes.
2020-07-13 00:52:50 +02:00
Vadim Zeitlin
e779450638 Merge branch 'tipwindow'
Miscellaneous wxTipWindow enhancements, including better high DPI
support.

See https://github.com/wxWidgets/wxWidgets/pull/1949
2020-07-12 22:31:08 +02:00
Vadim Zeitlin
32489c914c Merge branch 'vector-reverse-iter'
Fix wxVector reverse iterator base().

See https://github.com/wxWidgets/wxWidgets/pull/1948
2020-07-12 22:30:42 +02:00
Vadim Zeitlin
98241e21cd Merge branch 'colour-as-string'
Return empty string from wxColour::GetAsString() if it's invalid.

See https://github.com/wxWidgets/wxWidgets/pull/1947
2020-07-12 22:29:09 +02:00
tm
f6cc8ff52c Add GetOpenGLScaleFactor() to abstract OpenGL coordinates scaling
The fix for OpenGL coordinates when using high DPI in b134589cbb (Fix
OpenGL samples when using HiDPI displays, 2019-08-06) did fix it for GTK
3 and macOS, but broke it for MSW and other platforms not using pixel
scaling, as window coordinates are the same as OpenGL ones there, while
GetContentScaleFactor() can still return values > 1 even on these
platforms.

Provide new GetOpenGLScaleFactor() function abstracting this platform
difference and use it in all OpenGL samples to make them work correctly
in high DPI under all platforms.

Closes https://github.com/wxWidgets/wxWidgets/pull/1944

Closes #17391.
2020-07-12 22:28:29 +02:00
Ian McInerney
8f322ffb23 Replace g_clipboardAtom with GDK_SELECTION_CLIPBOARD
GDK_SELECTION_CLIPBOARD is the prefered way of referencing
the GdkAtom for the clipboard, and using it provides a clearer
distinction between the primary clipboard and the normal clipboard.
2020-07-12 20:14:41 +01:00
Stefan Csomor
01d7fa8116 adding utf8 as when data is read from the pasteboard 2020-07-12 20:59:32 +02:00
Stefan Csomor
1e64278150 macOS fixing potential crash in PasteboardWriter
using a pasteboard peeker tool lead to a crash when the drag pasteboard was accessed after our session has long finished. Make sure the writer is working correctly event after the data object is not valid anymore
2020-07-12 20:58:41 +02:00
Artur Wieczorek
95b5fcc0ea Use empty() function to check if vector is empty
Use this dedicated function instead of checking if size() function
returns zero/non-zero value.
2020-07-12 20:07:29 +02:00
Artur Wieczorek
c1cbc1aee7 Suppress MSVC++ performance warning
This is to prevent warning C4800: 'LRESULT': forcing value to bool 'true'
or 'false' (performance warning).
2020-07-12 20:04:59 +02:00
Artur Wieczorek
3feea201da Add tests of setting wxSpinCtrl base and range 2020-07-12 19:58:30 +02:00
Artur Wieczorek
a4928c0fde Use Catch in wxSpinCtrl unit tests
Use Catch instead of CppUnit for unit tests of wxSpinCtrl.
2020-07-12 19:58:30 +02:00
Artur Wieczorek
776b28cba7 Don't allow wxSpinCtrl range to include negative values if base != 10 (wxOSX)
For the sake of consistency with another ports only unsigned
hexadecimal numbers should be supported. To do so we need
to prevent:
- Setting a range including negative values if base == 16.
- Setting base != 10 if current range includes negative values.

Closes #18805.
2020-07-12 19:58:30 +02:00
Artur Wieczorek
845988e0ed Don't allow wxSpinCtrl range to include negative values if base != 10 (wxGTK)
Hexadecimal numbers are always unsigned in the native wxSpinCtrl
implementation under wxMSW so for the sake of consistency we need
to prevent:
- Setting a range including negative values if base == 16.
- Setting base != 10 if current range includes negative values.

See #18805.
2020-07-12 19:58:30 +02:00
Artur Wieczorek
ae1e93cbae Don't allow wxSpinCtrl range to include negative values if base != 10 (wxMSW)
In a native up-down control hexadecimal numbers are always unsigned (see
UDM_SETBASE message documentation) so we need to prevent:
- Setting a range including negative values if base == 16.
- Setting base != 10 if current range includes negative values.

See #18805.
2020-07-12 19:58:30 +02:00
Stefan Csomor
b2d4a9dedc adding data-transfer direction when getting native datatypes
we are publishing exactly what we have internally when data has to be get, and when setting, we might have more formats we can support
2020-07-12 17:53:10 +02:00
Ian McInerney
04ff2254a0 Ensure the clipboard contents are stored properly on GTK
GTK needs to be told the data on the clipboard can be stored
before the store is attempted.

Also, document that the clipboard behavior on GTK is very
dependent on the configuration of the user's machine.

Closes #10515
2020-07-12 00:39:33 +01:00
Maarten Bent
10ac26d6e5 Fix DPI of wxTipWindow
Take care to use the DPI of the display the window will be actually
displayed on and not that of its parent window, which can be different.
2020-07-11 19:59:40 +02:00