Commit Graph

13 Commits

Author SHA1 Message Date
Dimitri Schoolwerth
b5b208a179 Set svn properties on .cpp files.
Add missing svn:eol-style property to all .cpp files. Also set svn:keywords for .cpp files which don't have that property yet to Id, including src/osx/core/glgrab.cpp for consistency (it doesn't make use of the property).


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65561 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-09-17 11:17:55 +00:00
Vadim Zeitlin
6f07c007a5 Fix selection corner cases in wxOSX wxComboBox.
Don't crash in wxComboBox::GetString() if it's passed an invalid index.

Don't call GetString() with invalid index from GetStringSelection() if there
is no selection.

Do accept wxNOT_FOUND in SetSelectedItem() as it means, according to the docs,
that the existing selection should be reset.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65384 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-08-22 22:15:32 +00:00
Vadim Zeitlin
e567904ae6 Fix text text changed events sending in OS X combo box and text control.
Don't duplicate needlessly wxTextEntry functionality in wxTextCtrl.

Don't clear the combobox text entry part twice in wxComboBox::DoClear(), it is
supposed to only clear the item container contents as the base class Clear()
already calls wxTextEntry::Clear().

Do send text updated events from wxTextEntry itself as it applies to
wxComboBox just as well as to wxTextCtrl.

The unit tests now pass under wxOSX/Cocoa, not breaking them again would be
appreciated.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63881 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-04-06 18:46:29 +00:00
Vadim Zeitlin
005ac806ea Remove duplicated GetTextPeer() definitions from derived classes.
GetTextPeer() may be implemented directly in wxTextEntry under OS X, there is
no need to define it (identically) in wxTextCtrl and wxComboBox.

Also just call this method instead of duplicating its code in wxOSX
wxTextCtrl.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63878 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-04-06 18:46:14 +00:00
Vadim Zeitlin
f25cb0af6b Set the value passed to wxComboBox ctor in wxOSX/Cocoa.
The initial value was simply ignored, do use it now if it's specified, i.e.
non empty.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63877 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-04-06 18:46:09 +00:00
Vadim Zeitlin
96dfe7577a Suppress a harmless signed/unsigned comparison warning.
wxComboBox::FindString() used int loop index, change it to unsigned one.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63876 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-04-06 18:46:05 +00:00
Vadim Zeitlin
de5361faf3 Suppress unused parameter warnings.
observer argument of wxCFEventLoop::ObserverCallBack() and timestampsec one of
wxComboBox::OSXHandleClicked() were unused and generated gcc warnings.

wxComboBox::EnableTextChangedEvents() needs to be implemented but as there is
already a wxFAIL in it an extra warning is not really useful.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63875 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-04-06 18:46:00 +00:00
Kevin Ollivier
ec073e73d1 Implement case-insensitive find and read only support for Cocoa combobox.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63484 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-02-15 04:23:49 +00:00
Kevin Ollivier
72247c2f53 Fix mistake, though this assert is unfortunate since now FindString("whatever") will always assert under OS X Cocoa, even when it would find and return the position correctly.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63254 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-01-24 23:28:32 +00:00
Vadim Zeitlin
8e7262fca7 Replace wxLogWarning()s in wxOSX wxComboBox code with asserts.
This incidentally fixes compilation when not using PCH as wx/log.h was not
included but is also more correct as the messages meant for the programmer,
and not the user, should be given using asserts and not wxLog.

Also correct some asserts messages. In particular, don't mention the function
name in the message itself as it's already shown by the assert and using it in
the string itself isn't useful and simply introduces the risk of forgetting to
update it after refactoring, as happened here in r63105.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63243 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-01-24 09:13:40 +00:00
Kevin Ollivier
c84030e020 Implement native OS X ComboBox for OS X Cocoa, and implement wxTextEntry methods to share code between wxComboBox and wxTextCtrl.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63105 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-01-09 19:50:55 +00:00
Kevin Ollivier
f941a30bef Get the OS X Cocoa native combobox building by having the native code compile if wxOSX_USE_NATIVE_COMBOBOX is defined. It must be explicitly enabled by adding that define to the build flags as the native implementation is mostly just stubs right now.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63053 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-01-04 01:57:42 +00:00
Stefan Csomor
4ddfa282fa adding placeholders and work in progress files
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63028 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-12-31 08:39:13 +00:00