Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
66,139 Commits 1 Branch 330 Tags
b2ea56b4e9c774b65c54e7ce4c7c6a5ea5d4e1f6
Commit Graph

164 Commits

Author SHA1 Message Date
Artur Wieczorek
9df9e32a70 Get rid of unnecessary casts to wxPGProperty* 
These casts are unnecessary and can be removed.
 2019-04-28 17:04:07 +02:00
Artur Wieczorek
d06d403136 Replace 'while' loop with 'for' loop for simple iterations 
Using 'for' loop to do a simple iteration is more intuitive and makes the code simpler.
 2019-04-28 16:48:32 +02:00
Artur Wieczorek
50b1cfd0b5 Use dedicated function to change wxPGProperty flags 
Using wxPGProperty::ChangeFlag() function makes the code simpler and more readable.
 2019-04-28 16:38:48 +02:00
Artur Wieczorek
bd313b64ab Fix copying wxPGAttributeStorage 
We need implement copy ctor and assignment operator because we are going to do a shallow copy of wxPGHashMapS2P data member and therefore we have to manually update reference counters of the objects being referenced in this map.
 2019-04-28 16:35:11 +02:00
Artur Wieczorek
285bedc5e5 Always redraw wxPGProperty after changing its attribute 
Because changing some attributes of the property affects the format
of displayed value so the property has to be refreshed whether its
attribute is set through wxPGProperty::SetAttribute()
or wxPropertyGridInterface::SetPropertyAttribute().

Closes #18388.
 2019-04-19 22:23:34 +02:00
Artur Wieczorek
b569a429a2 Remove unnecessary position check 
Horizontally scrolled item can have a negative x-position.
 2018-12-28 14:02:04 +01:00
Artur Wieczorek
c86f795914 Move shared wxVector utilities to one place 2018-11-10 22:27:57 +01:00
Artur Wieczorek
e2115d0d6f Remove unneeded calls to c_str() 2018-11-10 20:44:54 +01:00
Artur Wieczorek
322d6874c3 Use wxVector<> instead of wxArrayPGProperty 2018-11-10 20:43:58 +01:00
Artur Wieczorek
7a7777cb4a Fix wxPGProperty::GetMainParent() function 
Traversing upwards in the tree should be stopped when parent is root or category property.
 2018-10-13 23:33:26 +02:00
Vadim Zeitlin
96ecfd8c77 Provide wxPGChoices ctor, Add(), Set() overloads taking wxStrings 
Allow passing an array of wxStrings in addition to an array of wxChar*
strings.
 2018-09-29 17:13:00 +02:00
Artur Wieczorek
31ab9d8f3f Make pointer to wxWindow a const argument. 
State of referenced window is not going to be changed and let caller know about it.
 2016-03-06 21:26:14 +01:00
Artur Wieczorek
ff788f05bb Move duplicated code to the shared function. 
Code to calculate label width in wxPropertyCategory::GetTextExtent and CalculateTextExtent is duplicated.
 2016-03-06 21:21:19 +01:00
Paul Cornett
01ccff2e05 Avoid comparing address of reference to NULL 
As GCC 6 points out, the compiler is free to assume a reference is never
null, and remove such a check
 2016-02-26 10:06:26 -08:00
Artur Wieczorek
3cc8b4ae37 wxBitmap::UseAlpha can be used only on wxMSW and wxOSX. 
This method is not implemented on all ports.
 2016-02-25 22:56:47 +01:00
Artur Wieczorek
c63b1604b3 Use native renderer to draw rectangle indicating that wxPG category property is selected. 
Because on some ports native renderers require a valid reference to the windows be drawn then it is necessary to implement and use new wxPGCellRenderer::DrawCaptionSelectionRect method which passes this  additional argument.
 2015-08-30 19:46:34 +02:00
Artur Wieczorek
7ce6cff5ab Extend functionality of wxPropertyGridInterface::SetPropertyColoursToDefault method. 
SetPropertyTextColour, SetPropertyBackgroundColour methods are able to set colours recursively for sub-properties but SetPropertyColoursToDefault method is not.
For the sake of consistency, SetPropertyColoursToDefault method is extended to have the same capabilities as SetPropertyTextColour and SetPropertyBackgroundColour. Behaviour and signature in default case (no recursion) is preserved.
For internal purposes there were also implemented helper methods in wxPGProperty class: SetDefaultColours, ClearCells.
 2015-08-27 19:14:52 +02:00
Artur Wieczorek
e0f5b49a07 Fixed searching the elements in wxArrayPGProperty. 
Use dedicated Index() function to search elements in wxArray instead of calling custom function.
 2015-07-20 21:50:30 +02:00
Artur Wieczorek
79794391e9 Declare wxPG_DEFAULT_IMAGE_SIZE as wxDefaultSize constant. 
wxDefaultSize is an equivalent of wxSize(-1,-1) but is more portable.
 2015-07-15 21:45:27 +02:00
Artur Wieczorek
4398e20655 Use wxDefaultCoord instead of explicit -1 value while initializing wxSize and wxPoint variables. 2015-07-15 21:45:08 +02:00
Artur Wieczorek
7d77168936 Refactor: Use dedicated methods to manipulate wxRect members. 2015-07-07 21:56:17 +02:00
Artur Wieczorek
9e77932278 Use wxBitmap::GetSize() to obtain size of the wxBitmap. 
When assigning wxBitmap size to wxSize variable there is not necessary to assign bitmap width and height separately.
 2015-07-06 22:13:23 +02:00
Artur Wieczorek
87f0b6fe80 Fix and refactor wxString wxPGProperty::GetFlagsAsString and SetFlagsAsString. 
Fixes the bug which could be observed if string containing more then one flag entry was provided to wxPGProperty::SetFlagsFromString. In this case property flags were not set properly (were not set all) due to the error in splitting the string into tokens (whole string instead of its individual token was taken to compare).
Lookup table used to map between flag values and their names is redesigned in order to reduce the size and to make indexing simpler. There are no longer NULL entries in the table and every flag name is identified explicitly by the corresponding flag value and not by the index of the name entry in the table. Thanks to this the relation between flag value and flag name is more clear and the loops in wxPGProperty::GetFlagsAsString/SetFlagsAsString can be simplified.
 2015-06-14 17:07:24 +02:00
Artur Wieczorek
8e2f1b47aa Use wxS macro with string literals. 
To make string literals notation consistent.
 2015-06-12 23:39:00 +02:00
Artur Wieczorek
4d4ece53f1 Use wxEmptyString instead of wxString(). 
To keep uniform notation of empty strings.
 2015-06-12 23:35:17 +02:00
Artur Wieczorek
6cc7811394 Fixed minor typos in comments. 
Yet another iteration.
 2015-06-09 20:04:27 +02:00
Artur Wieczorek
aeed3322f2 Fixed minor typos in comments. 2015-06-08 21:49:38 +02:00
Artur Wieczorek
c8088e479a Fixed minor typos in the name of variables. 2015-06-08 21:48:08 +02:00
Artur Wieczorek
1d9c1b35fd Use pre-increment operator to increment iterator in the loop. 
When the return value is ignored, the ++it is never less efficient than the it++.
 2015-06-07 23:05:42 +02:00
Artur Wieczorek
06013ea36f Reduce the scope of variables using to index single loop only. 
And adjust their types if necessary.
 2015-06-06 17:55:39 +02:00
Artur Wieczorek
ccd98c6ad9 Refactor: use <<= bit shift assignment operator in wxPGProperty::GetFlagsAsString. 
Use it instead of << operator which is used to just shift bits in one variable.
 2015-06-05 22:49:49 +02:00
Artur Wieczorek
f7322af25e Replace wxChar with wxStringCharType in wxPropertyGrid code. 2015-06-04 22:51:34 +02:00
Jan van Dijk
72a4c3a4d0 Don't test if a reference is null, this cannot happen. 
Testing for null references is unnecessary and just results in clang warnings.

Closes #17016.
 2015-06-03 17:08:30 +02:00
Artur Wieczorek
67bfb78ace Replace wxT() with wxS() in wxPropertyGrid code. 2015-05-31 19:20:11 +02:00
Artur Wieczorek
0508087ce2 Reduce the scope of variables using to indexing single loop only. 
And adjust their types if necessary (to have uniform types in the test expression).
 2015-05-28 19:39:14 +02:00
Artur Wieczorek
6908275ed2 Use wxDynamicCast() instead of IsKindOf() checks. 2015-05-28 19:20:12 +02:00
Artur Wieczorek
01cf62684c Use wxPGProperty::GetDepth() getter. 
Use it instead of getting direct access to the corresponding member variable.
 2015-05-27 21:15:28 +02:00
Artur Wieczorek
a39311bc2d Use HasExtraStyle() function to examine extra wxPG flags. 
This dedicated function to check the extra flag is used instead of doing explicit check of the value returned by GetExtraStyle() function.
 2015-05-21 20:10:26 +02:00
Artur Wieczorek
4b8e8adf16 Use wxString::empty() function calls to determine if string is empty in wxPG. 
Use this dedicated function instead of explicitly check if wxString::length() returns non-zero value.
 2015-05-15 22:34:25 +02:00
Artur Wieczorek
91144a2247 Fixed setting property label with wxPGproperty::SetLabel 
If there is a corresponding cell containing a cached text for column 0 then this text also needs to be updated when the label is changed.

See #16982.
 2015-05-10 18:50:25 +02:00
Dimitri Schoolwerth
8f8d58d193 Use wx-prefixed macros throughout the repository. 
Change {DECLARE,IMPLEMENT}_*CLASS and {DECLARE,BEGIN,END}_EVENT_TABLE
occurrences to use the wx-prefixed version of the macros.
 2015-04-23 22:00:35 +04:00
Artur Wieczorek
7c6943175b Prepare wxPG to build successfully when wxUSE_LONGLONG or wxUSE_DATETIME is disabled. 
Make the code ready to build even when wxLongLong and wxDateTime types are not available.
 2015-04-03 21:12:54 +02:00
Artur Wieczorek
6a7b95f419 Use predefined constants to represent common wxPG variant types (cont.). 
Instead of using individual string literals use globally defined constants representing wxPG variant types (wxLongLong, wxULongLong, wxArrayInt, etc.).
 2015-04-03 21:09:12 +02:00
Artur Wieczorek
5353a00180 Use wxVariant::IsType() function to check the type of variant values in wxPG. 
Since there is a dedicated function to check the type of variant then there is not necessary to call wxVariant::GetType() function and perform explicit comparisons of returned strings.
 2015-03-29 21:41:52 +02:00
Artur Wieczorek
35b53a8c30 Replace WX_PG_IMPLEMENT_PROPERTY_CLASS macro with simplified wxPG_IMPLEMENT_PROPERTY_CLASS macro. 
New macro have no obsolete parameters and its name conforms to the naming standard (prefixed with wx).

Closes #15541

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@78444 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
 2015-02-04 16:46:34 +00:00
Artur Wieczorek
1127820164 Encapsulate wxPGProperty::m_children member variable. 
Implement RemoveChild and SortChildren methods to perform operations on m_children member variable.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@78428 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
 2015-01-31 21:49:01 +00:00
Artur Wieczorek
1bac5cfbe0 Refactor property attribute names in wxPGProperty::GetAttribute calls. 
Use attribute constants instead of strings in wxPGProperty and wxPGDefaultRenderer classes and in NumericValidation() function.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@78400 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
 2015-01-21 17:06:16 +00:00
Artur Wieczorek
42a1064ea8 Implement deprecated wxPGProperty::GetValueString function only in wxPG 1.4 compatibility mode. 
This function was marked as deprecated in 2008.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@78391 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
 2015-01-19 19:58:32 +00:00
Artur Wieczorek
7a9ae4aecf Fix using WXWIN_COMPATIBILITY_3_0 in conditional blocks in wxPG code. 
Check the value of WXWIN_COMPATIBILITY_3_0 instead of checking whether it is defined.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@78369 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
 2015-01-13 16:41:33 +00:00
Artur Wieczorek
630b7fd5d7 Preserve alpha channel flag when rescaling bitmap in wxPGProperty::SetValueImage (when wxUSE_IMAGE == 0). 
Rescaled bitmap must have the same alpha channel flag as the source bitmap flag in order to be properly displayed.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@78368 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
 2015-01-12 20:37:34 +00:00