Commit Graph

70478 Commits

Author SHA1 Message Date
Vadim Zeitlin
04b9cee918 Fix testing for curl success in PowerShell
Of course doing the natural thing doesn't work in PowerShell.
2021-01-27 11:30:18 +01:00
Vadim Zeitlin
d59d51e0f2 Use curl command, not PowerShell alias
Aliasing curl to something completely different (Invoke-WebRequest) is
just evil, yet this is what Powershell 3+ does.
2021-01-27 11:12:15 +01:00
Vadim Zeitlin
99d088eec3 Add Python scripts directory to PATH to avoid pip warnings
They're really too annoying.
2021-01-27 11:11:20 +01:00
Vadim Zeitlin
cf65f47add Revert "Suppress pip warning about installing scripts not in PATH"
This reverts commit 2eaa7a21b0 because the
--no-warn-script-location option only exists in Python 3.9+ apparently
and we don't want to require such a new version just for this.
2021-01-27 10:49:58 +01:00
Vadim Zeitlin
6a170343ae Disable the tests if launching httpbin failed for some reason
This is not ideal, but will have to do for now.
2021-01-27 10:04:31 +01:00
Vadim Zeitlin
4bdbbeca4a Redirect httpbin error output to the log file too
This can be at least as useful as stdout.
2021-01-27 10:04:09 +01:00
Vadim Zeitlin
b394bb1b87 Show httpbin output if the test failed, not if it succeeded
This output is mostly useful for diagnosing errors, so it's not very
useful to show it only after successful test completion in after_test
command.
2021-01-27 10:01:53 +01:00
Vadim Zeitlin
2eaa7a21b0 Suppress pip warning about installing scripts not in PATH
We don't care about it here, as we use full paths anyhow.
2021-01-27 09:49:03 +01:00
Vadim Zeitlin
c625d2c001 Try using Python 3 with httpbin
Use 3.5 which is currently available on all AppVeyor Windows images, see
https://www.appveyor.com/docs/windows-images-software/#python
2021-01-27 09:29:02 +01:00
Andreas Falkenhahn
7555d1b245 Fix expansion of the last column in macOS wxDataViewCtrl
It should always take the rest of the available space.

See #14939.
2021-01-26 22:58:01 +01:00
Vadim Zeitlin
623c4811ab Run httpbin in appveyor.yml to be able to stop it later
There is no way to stop a background task simply and safely with
cmd.exe, but in appveyor.yml we can use PowerShell, so use its job
support to do it instead.

This is important because AppVeyor waits until all jobs launched by the
script terminate, so without stopping the background job all builds
waited for an hour before timing out.
2021-01-26 22:50:43 +01:00
Vadim Zeitlin
d5ebe48d93 Use httpbin for error status with body test too
Although httpbin doesn't return any body for the other 4xx statuses, it
does make an exception for this one, so we can use it for testing
instead of the even less reliable httpstat.us which regularly returns
503 server error instead of the expected 418.

This probably also makes the workaround for Ubuntu 14.04 unnecessary, so
remove it.
2021-01-26 22:24:18 +01:00
Stefan Csomor
17239d5c3d macOS add fallback for retrieving color channels from dynamic system colors on pre 10.14 systems
the channel conversion was only working on systems starting from 10.14, using the CGColor as a fallback
2021-01-26 16:40:41 +01:00
VZ
75b4f5439a Fix setting WX_TEST_WEBREQUEST_URL in AppVeyor builds
Don't use quotes around the value, they're not special for cmd.exe
and remain part of the actual variable value.

Co-authored-by: Maarten <MaartenBent@users.noreply.github.com>
2021-01-25 18:22:40 +01:00
Vadim Zeitlin
56a5512b37 Merge branch 'selstore-insert-fix'
Fix state of multiple items inserted into wxSelectionStore and improve
its tests.

See https://github.com/wxWidgets/wxWidgets/pull/2182
2021-01-25 13:02:34 +01:00
Vadim Zeitlin
867a02e646 Merge branch 'webview-edge-unload'
Simplify and fix wxWebViewEdge initialization.

See https://github.com/wxWidgets/wxWidgets/pull/2188
2021-01-25 13:01:45 +01:00
Vadim Zeitlin
b65799448b Merge branch 'gtk-value'
Use wxGtkValue RAII wrapper in wxGTK code.

See https://github.com/wxWidgets/wxWidgets/pull/2187
2021-01-25 13:01:03 +01:00
Vadim Zeitlin
9130f8bfc6 Don't change orthogonal alignment in wxSizerFlags::CenterXXX()
It was unexpected that using wxSizerFlags().Right().CentreVertical()
didn't right-align the item because CentreVertical() reset the alignment
in the horizontal direction rather than just setting it in the vertical
one, so change this, document the new behaviour explicitly and add a new
unit test checking for it.

Closes #18989.
2021-01-25 12:58:04 +01:00
Vadim Zeitlin
caf5a62fd9 Use different sections for different flags in wxGridSizer test
No real changes, just organize the tests a bit better.
2021-01-25 00:53:24 +01:00
Vadim Zeitlin
fa4339a935 Initialize wxGtkValue in a way not requiring C++11
As we still support C++98, don't use G_VALUE_INIT as the initializer:
it's a braced-init-list, which is only allowed in C++11.

Co-Authored-By: Paul Cornett <paulcor@users.noreply.github.com>
2021-01-25 00:49:27 +01:00
Vadim Zeitlin
08d8d12872 Get rid of CppUnit boilerplate in wxGridSizer unit test
No real changes, just simplify and use CHECK() instead of
CPPUNIT_ASSERT_EQUAL() (which is the same as REQUIRE()).
2021-01-25 00:48:30 +01:00
Vadim Zeitlin
b48c46285c Avoid creating empty bitmap in MSW wxNotebook::OnPaint()
It can apparently happen that the window has 0 size and in this creating
the bitmap is useless and just triggers an assert.

Closes #18879.
2021-01-25 00:32:12 +01:00
Vadim Zeitlin
bde7cfb1a7 Show WX_TEST_WEBREQUEST_URL being used in the test
Make it clear which URL do we actually use.
2021-01-25 00:28:11 +01:00
Vadim Zeitlin
32cdda65bb Use pip for httpbin in Mac Travis CI builds
Docker isn't available under Mac, unfortunately.

Notice that it's still better to use Docker if it is available, rather
than using pip everywhere, as pip has trouble installing httpbin in the
Ubuntu 14.04 build, for example.
2021-01-25 00:25:04 +01:00
Vadim Zeitlin
bc825de1fe Simplify and make more robust wxWebViewEdge initialization
Get rid of ms_isInitialized as it must be kept synchronized with
ms_loaderDll.IsLoaded() anyhow, and it's simpler to not have it at all
rather than ensuring this.

Also ensure that calling Initialize() again, after doing it first
unsuccessfully, doesn't assert because ms_loaderDll is already loaded,
by only leaving it with a valid handle if the initialization succeeded.

Closes #19041.
2021-01-25 00:15:24 +01:00
Vadim Zeitlin
4de8857c85 Add wxDynamicLibrary::Attach()
This is symmetric with Detach() and can be useful and doesn't cost
anything to have.
2021-01-25 00:15:24 +01:00
Vadim Zeitlin
3568a160a9 Use wxGtkValue RAII wrapper in wxGTK code
wxGtkValue class was added back in 3f84cb17ca (Add wxActivityIndicator
control., 2015-03-06), but somehow never used. Start using it now
(better late than never...) as it makes the code simpler, shorter and
more robust.

No real changes.
2021-01-24 23:55:43 +01:00
Julian Smart
678b641950 Fix initial focus problem for hidden windows under Mac
Assume that hidden windows do accept focus because, even if this is
still wrong, in general, it is less harmful than wrongly returning false
from CanFocus() for them.

Closes #18987.
2021-01-24 23:45:24 +01:00
PB
e094734a89 Fix numbered list in wxMenuEvent docs
Just remove the empty line which prevented doxygen from generating a numbered list.
2021-01-24 21:58:59 +01:00
Andreas Falkenhahn
b2675d6a60 Fix sending event when cancelling editing in wxDVC under Mac
Move existing code for sending wxEVT_DATAVIEW_ITEM_EDITING_DONE to a new
sendEditingDoneEvent:isCancelled function and also call it, with true
argument, from cancelOperation: to generate the expected event.

Closes #17835.
2021-01-24 21:16:23 +01:00
Vadim Zeitlin
c714e75555 Generate wxEVT_CHAR_HOOK events before accelerators
This is more consistent with the other ports and allows to use
wxEVT_CHAR_HOOK handler to preempt processing of the accelerators (but
notice that under macOS this only works for accelerators that are part
of wxAcceleratorTable and not those associated with the menu items, as
the latter ones are not handled by this code at all).

Also simplify the code structure a little by getting rid of an
unnecessary and more confusing than helpful "handled" variable.
2021-01-24 21:09:05 +01:00
Vadim Zeitlin
f8d4bba9e7 Fix handling of accelerators in wxOSX
Check accelerator tables when handling wxEVT_CHAR_HOOK, not
wxEVT_KEY_DOWN, as we don't get the latter at all for some events, e.g.
Cmd-Alt-1 doesn't generate wxEVT_KEY_DOWN (which looks like another bug)
but does generate wxEVT_CHAR_HOOK.

Closes #13937.
2021-01-24 20:57:20 +01:00
Vadim Zeitlin
5f30f79bc8 Remove unnecessary checks of wxEvent::GetSkipped()
HandleWindowEvent() already returns false if the event handler skipped
the event, there is no need to test for it explicitly.

No real changes.
2021-01-24 20:56:38 +01:00
Stefan Csomor
0f4c65dd4f respecting UTI string rules when constructing native format in wxDataFormat::SetId
adding part from 4ae329472c
2021-01-24 19:51:33 +01:00
Stefan Csomor
3ccfa976aa guard against nullptr exception in wxLogGui::Flush
happened eg during wxUnitialize in dnd sample on macOS (open new frame, add shape, quit app)
2021-01-24 19:40:01 +01:00
Julian Smart
8e26b8d54e Fix wxSYS_COLOUR_BTNFACE value under macOS < 10.14
Use fallback value which isn't just RGB(0,0,0) when building under 10.15
but running under 10.13.

Closes #18977.
2021-01-24 19:09:31 +01:00
Vadim Zeitlin
9307fa6f89 Run httpbin locally for the tests in the CI builds
Run httpbin (either directly or inside a container) and set
WX_TEST_WEBREQUEST_URL to point to localhost.

Note that it is important _not_ to have a trailing slash in the root
URL, otherwise WebRequest::Auth::Digest test would fail.
2021-01-24 19:04:41 +01:00
Paul Cornett
4d7ca07211 Fix RTL layout of menus with GTK
Set layout direction for all menu items and sub-menus,
setting just the top level menu doesn't do much
2021-01-24 09:20:54 -08:00
Paul Cornett
4fdcdc07d2 Set horizontal scrollbar layout direction from SetLayoutDirection()
Rather than when it is created, which is too early
2021-01-24 09:09:49 -08:00
Paul Cornett
043183356b Set text layout direction earlier during window creation
Code later in the same function was using the direction before it was set
2021-01-24 08:59:12 -08:00
Stefan Csomor
c5394cea63 Fix handling of standard edit commands in context menu under Mac
Feed back standard commands like copy, paste into wxMenItem if possible.

This way commands that don't exist in the global menubar can still be
fed back eg when originating from a context menu.

See #18738.
2021-01-24 15:54:02 +01:00
Vadim Zeitlin
d9d44c8585 Increase wxWebRequest tests timeout
10s seems to often be not long enough for the Travis/AppVeyor machines.
2021-01-24 02:01:58 +01:00
Vadim Zeitlin
949b66c0f5 Use a different httpbin mirror by default
This one seems slower, but might be more reliable.
2021-01-23 16:46:02 +01:00
Vadim Zeitlin
86f9778ea9 Add a unit test exercising the bug fix in the parent commit
This test used to fail, but passes now.
2021-01-23 16:40:30 +01:00
rk
fd839c4bd6 Fix selection when inserting multiple items into wxSelectionStore
When inserting more than one item into wxSelectionStore in the
default-selected state, the state of all the items bug the first one was
wrongly set to "selected" initially.

Just fix the typo in the AddAt() call, which was passed a wrong
variable, to fix this.

Closes #19040.
2021-01-23 16:40:30 +01:00
Vadim Zeitlin
6b3ff511ee Get rid of all CppUnit boilerplate in wxSelectionStore test
This simplifies the code and allows running the test cases individually
from the command line.
2021-01-23 16:40:30 +01:00
Vadim Zeitlin
a1cca242a4 Use CHECK() instead of CPPUNIT_ASSERT in wxSelectionStore test
No real changes, just simplify the code. Notably we don't need explicit
"u" suffix on the literal constants any longer as CATCH is smart enough
to compare signed and unsigned integers correctly without it.
2021-01-23 16:40:30 +01:00
Vadim Zeitlin
8e5836908c Use wxSelectionStore object instead of a pointer in the test
Just simplify the code, there is no need to allocate and free a pointer
when we can just use an object.

No real changes.
2021-01-22 22:32:20 +01:00
Kaya Zeren
0157ea11a1 Turkish translation update
Turkish translation update
2021-01-22 02:19:06 +03:00
Paul Cornett
c5aee91847 Fix highlighting wxTimePickerCtrl fields on GTK
GtkEntry automatically selects all the text in many situations,
so do the field highlighting later to override GTK's behavior.
2021-01-21 11:38:22 -08:00