Commit Graph

42 Commits

Author SHA1 Message Date
Vadim Zeitlin
3d278ee75f Avoid warnings about operations on different enums in C++20 mode
Arithmetic operations on the elements of different enums are deprecated
in C++20 and the latest compiler versions warn about them.

While individual warnings could be fixed in wxWidgets itself (although
it would be quite an effort to do it for all ~500 of them), it wouldn't
help with the same warnings in the applications using wx, so prefer to
do it by explicitly defining the operations on the enums that can be
combined with each other by using wxALLOW_COMBINING_ENUMS() macro,
except for a single warning in wxTar code where it's easier to just not
use an anum at all.
2021-04-25 18:59:20 +02:00
PB
f57f214122 Remove BCC-specific hdrstop pragma from everywhere 2020-10-12 21:58:37 +02:00
orbitcowboy
6e6e1cf25b Fix mismatching delete in wxTarOutputStream code
Free the buffer allocated with new[] using delete[] and not just
"delete".

Closes https://github.com/wxWidgets/wxWidgets/pull/1685
2019-12-23 16:49:06 +01:00
Paul Cornett
fe1737d399 Reduce the scope of some local variables 2019-04-05 10:44:02 -07:00
Vadim Zeitlin
e54ec6c191 Add wxTarHeaderBlock::Clear() method encapsulating memset()
Using memset() with objects of (non-trivial) class type results in a
-Wclass-memaccess warning with g++ 8, so avoid doing this.

Add a Clear() method allowing to do the same thing without breaking
encapsulation.
2018-05-21 12:27:26 +02:00
Vadim Zeitlin
d8200f1096 Remove unused wxTarHeaderBlock copy ctor
These objects are never copied, and if they were, the default
(compiler-generated) copy ctor would do the same thing this explicitly
defined copy ctor did, so just remove it.
2018-05-20 17:59:20 +02:00
Vadim Zeitlin
58e6355695 Rename wxTarEntryPtr_ to wxTarEntryPtr
Remove the unusual underscore at the end of the type and use a single
wxDEFINE_SCOPED_PTR_TYPE() macro instead of 2 of them to simplify code.
2018-05-20 17:58:09 +02:00
Vadim Zeitlin
d9d5e1d5f7 Remove unused wxDEFINE_SCOPED_PTR_TYPE(wxTarHeaderBlock)
wxTarHeaderBlockPtr defined by this macro was never used, so just remove
it.
2018-05-20 17:57:17 +02:00
orbitcowboy
f423b88ded Replace post-increment on iterators with pre-increment
This is a micro-optimization, as pre-increment is at least as efficient
as post-increment and typically slightly more so because it doesn't need
to make a copy of the iterator, and better conforms to the prevailing
C++ style.

Closes https://github.com/wxWidgets/wxWidgets/pull/655
2017-12-29 19:59:24 +01:00
Paul Cornett
99858d4628 Use wxString::empty() instead of comparison to wxEmptyString 2017-02-18 11:11:21 -08:00
Paul Cornett
96826d80d2 Use wxString::clear() instead of assignment to wxEmptyString 2017-02-18 11:00:26 -08:00
Dimitri Schoolwerth
31145b8e3a Fix some typos, no code changes (besides strings) 2015-06-05 02:54:46 +04:00
Dimitri Schoolwerth
8f8d58d193 Use wx-prefixed macros throughout the repository.
Change {DECLARE,IMPLEMENT}_*CLASS and {DECLARE,BEGIN,END}_EVENT_TABLE
occurrences to use the wx-prefixed version of the macros.
2015-04-23 22:00:35 +04:00
Vadim Zeitlin
bdef0d8ff7 Fix possible crash in TAR header parsing code.
Check that the iterator is valid before using its value, otherwise the
validity check was useless.

Closes #15888.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@75642 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2014-01-19 11:44:54 +00:00
Vadim Zeitlin
3f66f6a5b3 Remove all lines containing cvs/svn "$Id$" keyword.
This keyword is not expanded by Git which means it's not replaced with the
correct revision value in the releases made using git-based scripts and it's
confusing to have lines with unexpanded "$Id$" in the released files. As
expanding them with Git is not that simple (it could be done with git archive
and export-subst attribute) and there are not many benefits in having them in
the first place, just remove all these lines.

If nothing else, this will make an eventual transition to Git simpler.

Closes #14487.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74602 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2013-07-26 16:02:46 +00:00
Dimitri Schoolwerth
80fdcdb90e No changes, synchronised source names that appear commented at the top of files with the actual path to the files.
Fixed commented names (path, filename, and extension) of files in include/ and src/. Prepended the names in src/ with "src/" everywhere, while starting those in include/wx/ with "wx/".

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@67254 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2011-03-20 00:14:35 +00:00
Michael Wetherell
1682f86006 Fix for file length fixup.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63303 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2010-01-28 21:46:18 +00:00
Vadim Zeitlin
9a83f86094 Globally replace _T() with wxT().
Standardize on using a single macro across all wxWidgets sources and solve the name clash with Sun CC standard headers (see #10660).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@61508 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-07-23 20:30:22 +00:00
Vadim Zeitlin
af58844636 Add information about the log message generation location to wxLog.
This means that wxLog::DoLogRecord() can now retrieve the file name, line
number and the function where the message was logged.

An unfortunate consequence of this change is that now

	if ( condition )
		wxLogError("Whatever");

results in a warning from g++ 4.x with -Wparentehses, so extra parentheses had
to be added in many places.

Finally, also allow storing arbitrary attributes in wxLogRecordInfo. This had
to be added to implement our own overloaded wxLogStatus() and wxLogSysError()
and will probably be useful for the others as well.


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@61363 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-07-09 20:26:34 +00:00
Vadim Zeitlin
664e13143e renamed wx/ptr_shrd.h to wx/sharedptr.h; split wx/ptr_scpd.h in wx/scopedptr.h and wx/scopedarray.h; extracted common parts into new wx/checkeddelete.h
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@58634 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2009-02-03 12:01:46 +00:00
Vadim Zeitlin
b161b1549c test ok in the record reading loop as otherwise we never exit from it if there is an invalid character in the record
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@54641 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-07-15 17:31:40 +00:00
Michael Wetherell
d7a4c4bd39 Work around another buggy getgrgid_r.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@53243 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-04-17 14:39:31 +00:00
Julian Smart
2eb37f730d Fixed bug for chars with ASCII value > 127, explicitly casting to an unsigned char (Sebastian Gottschalk)
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@52491 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-03-14 14:16:39 +00:00
Michael Wetherell
dd0af4bb63 Always write end record unless one has already been written.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@51008 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-01-03 17:09:10 +00:00
Michael Wetherell
f2e582dda8 Cache user and group name as these can be expensive to get on some systems.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@49043 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2007-10-04 15:59:09 +00:00
Václav Slavík
8650108199 don't use implicit wxString->char*/wchar_t* conversion, it will not be available in wxUSE_STL build in the future
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@46391 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2007-06-10 17:42:41 +00:00
Václav Slavík
163d9efc6b avoid conversion to wchar_t* when getting UTF-8 value in UTF-8 build
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@45972 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2007-05-11 20:05:37 +00:00
Václav Slavík
c9f7896861 first phase of transition to unified Unicode build:
1. changed c_str() to return wxCStrData (implicitly convertible to wxChar*)
2. added template type-safe wrappers for vararg functions
3. added wxUniChar class representing single Unicode character
4. changed wxString::operator[] and wxString::iterator to return wxUniChar


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@44865 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2007-03-17 10:26:10 +00:00
Paul Cornett
ca2261d33f restore declaration inline specifier, and make definition match
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@44087 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2007-01-01 22:27:42 +00:00
Paul Cornett
ffdbfc4a76 remove inline from declaration of functions which are not inline
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@44083 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2007-01-01 19:49:10 +00:00
Michael Wetherell
e3a10e0c62 Revert last commit.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@43887 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-12-09 22:28:11 +00:00
Paul Cornett
61d8dec77f static functions don't need an instance
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@43857 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-12-07 09:00:52 +00:00
Vadim Zeitlin
0a704d3973 call base class ctor in copy ctors explicitly (fixes gcc warnings with -Wextra)
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@43020 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-11-04 11:16:03 +00:00
Michael Wetherell
7bb82a7415 Fix setting the large file flag.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42879 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-11-01 00:49:50 +00:00
Michael Wetherell
ea92316229 Some watcom warnings.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42731 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-10-30 17:03:56 +00:00
Michael Wetherell
5f77e766a3 Make m_typeflag an int.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42679 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-10-29 22:31:26 +00:00
Michael Wetherell
489a164c1c Rename wxSTREAM_FILEEXTENSION to wxSTREAM_FILEEXT.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42621 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-10-29 16:47:20 +00:00
Michael Wetherell
6df6e35a3e Fixes for semicolons, commas and wxSTRING_MAXLEN from Wlodek Szafran.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42605 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-10-29 07:37:09 +00:00
Michael Wetherell
1cc42ce322 Comment out compile time check.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42534 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-10-27 15:02:22 +00:00
Michael Wetherell
a793401243 Remove header now not needed here.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42531 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-10-27 14:32:26 +00:00
Michael Wetherell
45c64b28ba Compile fix for --enable-stl.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42526 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-10-27 14:14:54 +00:00
Michael Wetherell
dd1462c3f9 Add tar streams.
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42505 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2006-10-27 09:28:54 +00:00