Actual implementation of IsCharOk() didn't correspond to the comments in
it or near the function declaration which stated that it's never called
with ch='-' as argument -- it was called with it and called IsMinusOk()
right before a comment saying that it doesn't need to do it, which was
very confusing.
Fix this by making the behaviour really correspond to the comments and
handling '-' at the base class level. This required introducing a new
pure virtual CanBeNegative() function, but it's going to be useful for
other things later too.
Still keep IsMinusOk() helper, but make it private now because it
doesn't need to be called from the derived class IsCharOk() any longer.
There is just no need to do it manually, when the compiler can do the
job perfectly well itself.
No real changes, but this will simplify the upcoming refactoring.
Don't apply the workaround required for NSRoundedBezelStyle and
NSTexturedRoundedBezelStyle, i.e. enlarging too small buttons, if these
bezel styles are not used. In particular, avoid enlarging buttons with
wxBORDER_NONE or wxBORDER_SIMPLE.
Follow-up to 0941b25.
Simplify code and use CHECK() rather than REQUIRE(), which is what
CPPUNIT_ASSERT() is defined as, to continue running the tests even if
some of them fail.
Using IWICBitmapClipper it is possible to get a clipped version
of the source bitmap so it should be used instead of manual way
with extracting pixels to the memory.
Add wxRIBBON_ART_PANEL_HOVER_BORDER_COLOUR and
wxRIBBON_ART_PANEL_HOVER_BORDER_GRADIENT_COLOUR to allow further
customization of wxRibbon panels.
Closes https://github.com/wxWidgets/wxWidgets/pull/2239
Using docker results in errors due to rate limit on pulling, so try to
reduce its use as much as possible. It still has to be used under Ubuntu
14.04 because it has a version of Python too old to work with HTTPS
servers using SNI and so using pip fails there.
Change "make install" to install catalog files with version suffix and
modify the sources to look for suffixed catalog first, while still
falling back to just the base name if the variant with the version is
not found, because the message catalogs are copied manually in practice
under MSW/macOS systems and so won't have the version suffix there.
This allows to make message catalogs installed by different
wxWidgets versions to coexist on the same system, see
https://groups.google.com/g/wx-users/c/L9gC8UgrO6Y
Closes https://github.com/wxWidgets/wxWidgets/pull/2219
Co-Authored-By: Vadim Zeitlin <vadim@wxwidgets.org>
After the previous commit the coords stored by wxGridCellWithAttr have
become redundant as the coords are now also stored as part of the key
used for an attributes map. With then only an attribute remaining in
wxGridCellWithAttr it can be removed completely, letting the value of
an attributes map point directly to a (ref-counted) attribute instead.
Multiply the number of rows in the grid sample by a factor of 10. This
demonstrates the slowness with attribute lookups better when using
checkered (Ctrl+Shift+K) or coloured (Ctrl+Shift+L) cells, as filling
the grid is slowed down by way more than a factor of 10. Scrolling also
becomes less responsive the further away from the home cell the view is.
As a result of increasing the row count also move the cells positioned
near the end of the grid there again, and don't use fixed coords for
them.
Add options to fill grid either half (checkered cells) or fully (all
cells coloured) with attributes. Available from Grid > "Toggle Checkered
Cells" and "Toggle Coloured Cells".
A wxEVT_UPDATE_UI handler expects the parent of the extra control panel
to be at least a wxFileDialogBase. However with wxMac when showing file
types the extra control gets reparented and has the panel containing
file type controls as a parent.
Fix by not reparenting in case the extra control itself already is
a panel, and then instead use the extra control as a container for
the file type controls.
Simply set the relevant variable while changing selection and give
the extra control a chance to update.
Note that updating the UI currently asserts with the dialog sample if
wxOSX_FILEDIALOG_ALWAYS_SHOW_TYPES is 1 (toggable with Ctrl+Cmd+S in
the sample), This will be fixed in the next commit.
When using both an extra control and wxOSX_FILEDIALOG_ALWAYS_SHOW_TYPES
set to 1 to show file types, the controls for the latter stretch towards
the dialog's width.
Fix by not stretching the wxChoice used for filtering and surrounding
the file type controls with stretching spacers instead. This makes
the filter controls appear the same as without an extra control:
horizontally centred and not stretching.
Add some common architecture-dependent directories to the list of
subdirectories that should be ignored.
For Win32 the directory name x86 is also common.
For Win64 the directory names Win64 and x86_64 are frequently in use,
too.
Closes https://github.com/wxWidgets/wxWidgets/pull/2233
When configured with --enable-permissive option, add -fpermissive to C++
flags, not C flags, to avoid the gcc warning
command-line option '-fpermissive' is valid for C++/ObjC++ but not for C
when compiling C code.
Closes https://github.com/wxWidgets/wxWidgets/pull/2232
Fix missing events for in-document navigation with wxWebViewEdge,
implement Find() for it and add wxEVT_WEBVIEW_FULLSCREEN_CHANGED for it
and wxGTK.
See https://github.com/wxWidgets/wxWidgets/pull/2227
Check that the EOL used in the file corresponds to the expected one for
its extension, in addition to checking that EOLs are consistent.
Closes https://github.com/wxWidgets/wxWidgets/pull/2228
