From ff788f05bb088822fa52c9b893cd9151148b2234 Mon Sep 17 00:00:00 2001 From: Artur Wieczorek Date: Sun, 6 Mar 2016 21:21:19 +0100 Subject: [PATCH] Move duplicated code to the shared function. Code to calculate label width in wxPropertyCategory::GetTextExtent and CalculateTextExtent is duplicated. --- src/propgrid/property.cpp | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/propgrid/property.cpp b/src/propgrid/property.cpp index 0e992becc1..6b7d849be6 100644 --- a/src/propgrid/property.cpp +++ b/src/propgrid/property.cpp @@ -2930,20 +2930,23 @@ wxString wxPropertyCategory::GetValueAsString( int argFlags ) const return wxPGProperty::GetValueAsString(argFlags); } +static int DoGetTextExtent(const wxWindow* wnd, const wxString& label, const wxFont& font) +{ + int x = 0, y = 0; + wnd->GetTextExtent(label, &x, &y, 0, 0, &font); + return x; +} + int wxPropertyCategory::GetTextExtent( const wxWindow* wnd, const wxFont& font ) const { if ( m_textExtent > 0 ) return m_textExtent; - int x = 0, y = 0; - ((wxWindow*)wnd)->GetTextExtent( m_label, &x, &y, 0, 0, &font ); - return x; + return DoGetTextExtent(wnd, m_label, font); } void wxPropertyCategory::CalculateTextExtent( wxWindow* wnd, const wxFont& font ) { - int x = 0, y = 0; - wnd->GetTextExtent( m_label, &x, &y, 0, 0, &font ); - m_textExtent = x; + m_textExtent = DoGetTextExtent(wnd, m_label, font); } // -----------------------------------------------------------------------