Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix rendering artifacts in wxSplitterWindow sash

Browse Source 
SizeWindows() optimized rendering calls to DrawSash() too aggressively
and wouldn't repaint e.g. slowly moving sash with wxSP_LIVE_UPDATE
enabled, even though child windows were repositioned.

Fix by always painting the sash from SizeWindows().
This commit is contained in:
Václav Slavík
2016-11-14 20:07:22 +01:00
parent d3497d32ec
commit fd9e71afb7
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/generic/splitter.cpp
View File

@@ -656,8 +656,6 @@ void wxSplitterWindow::SetSashPositionAndNotify(int sashPos)
// including the edges next to the sash. // including the edges next to the sash.
void wxSplitterWindow::SizeWindows() void wxSplitterWindow::SizeWindows()
{ {
int oldSashPosition = m_sashPosition;
// check if we have delayed setting the real sash position // check if we have delayed setting the real sash position
if ( m_requestedSashPosition != INT_MAX ) if ( m_requestedSashPosition != INT_MAX )
{ {
@@ -723,11 +721,8 @@ void wxSplitterWindow::SizeWindows()
GetWindow1()->SetSize(border, border, w1, h1); GetWindow1()->SetSize(border, border, w1, h1);
} }
if ( oldSashPosition != m_sashPosition ) wxClientDC dc(this);
{ DrawSash(dc);
wxClientDC dc(this);
DrawSash(dc);
}
} }
// Set pane for unsplit window // Set pane for unsplit window