From fbe979db94775eb82d64c3cac9a5d1bd3e7e2a59 Mon Sep 17 00:00:00 2001 From: Benjamin Williams Date: Tue, 6 Nov 2007 14:02:44 +0000 Subject: [PATCH] aui dock renumbering fix git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/branches/WX_2_8_BRANCH@49682 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/aui/framemanager.cpp | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/aui/framemanager.cpp b/src/aui/framemanager.cpp index 2223316795..a725687cf8 100644 --- a/src/aui/framemanager.cpp +++ b/src/aui/framemanager.cpp @@ -435,13 +435,18 @@ static void RemovePaneFromDocks(wxAuiDockInfoArray& docks, // dock has rows with numbers 0,2,5, they will become 0,1,2 static void RenumberDockRows(wxAuiDockInfoPtrArray& docks) { - int i, dock_count, j, pane_count; + int i, dock_count; for (i = 0, dock_count = docks.GetCount(); i < dock_count; ++i) { wxAuiDockInfo& dock = *docks.Item(i); dock.dock_row = i; - for (j = 0, pane_count = dock.panes.GetCount(); j < pane_count; ++j) - dock.panes.Item(j)->dock_row = i; + + // (BIW) I believe these lines are wrong because they are modifying + // the original pane structures, which should be avoided as much + // as possible. + + //for (j = 0, pane_count = dock.panes.GetCount(); j < pane_count; ++j) + // dock.panes.Item(j)->dock_row = i; } }