Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed bug in wxDialUpManagerMSW::GetISPNames - uses realloc() without checking for NULL, leading to a memory leak (Sebastian Gottschalk)

Browse Source 
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@52494 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Julian Smart
2008-03-14 14:18:15 +00:00
parent 8a5a7042f1
commit fb9bea06cf
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/msw/dialup.cpp
View File

@@ -709,7 +709,13 @@ size_t wxDialUpManagerMSW::GetISPNames(wxArrayString& names) const
if ( dwRet == ERROR_BUFFER_TOO_SMALL ) if ( dwRet == ERROR_BUFFER_TOO_SMALL )
{ {
// reallocate the buffer // reallocate the buffer
rasEntries = (RASENTRYNAME *)realloc(rasEntries, size); void *n = realloc(rasEntries, size);
if (n == NULL)
{
free(rasEntries);
return 0;
}
rasEntries = (RASENTRYNAME *)n;
} }
else if ( dwRet != 0 ) else if ( dwRet != 0 )
{ {