Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize wxNumericPropertyValidator::Validate method.

Browse Source 
Remove second unnecessary casting from wxWindow to wxTextCtrl and use wxTextCtr::IsEmpty() function to check directly if the text control contains any text instead of examining retrieved string value.
This commit is contained in:
Artur Wieczorek
2015-05-27 21:13:09 +02:00
parent 3f94084e29
commit f740e5f784
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/propgrid/props.cpp
View File

@@ -200,18 +200,12 @@ bool wxNumericPropertyValidator::Validate(wxWindow* parent)
if ( !wxTextValidator::Validate(parent) ) if ( !wxTextValidator::Validate(parent) )
return false; return false;
wxWindow* wnd = GetWindow(); wxTextCtrl* tc = wxDynamicCast(GetWindow(), wxTextCtrl);
if ( !wxDynamicCast(wnd, wxTextCtrl) ) if ( !tc )
return true; return true;
// Do not allow zero-length string // Do not allow zero-length string
wxTextCtrl* tc = static_cast<wxTextCtrl*>(wnd); return !tc->IsEmpty();
wxString text = tc->GetValue();
if ( text.empty() )
return false;
return true;
} }
#endif // wxUSE_VALIDATORS #endif // wxUSE_VALIDATORS