No changes, just use AutoHBITMAP instead of manual DeleteObject() in wxMSW.

Use RAII AutoHBITMAP class instead of manually calling DeleteObject() on
temporary bitmaps in wxMSW wxImageList and wxBitmap code.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65962 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2010-10-30 23:51:09 +00:00
parent 2e7a64e9e6
commit f7196178a5
2 changed files with 10 additions and 19 deletions

View File

@@ -1650,7 +1650,8 @@ HICON wxBitmapToIconOrCursor(const wxBitmap& bmp,
// Create an empty mask bitmap.
// it doesn't seem to work if we mess with the mask at all.
HBITMAP hMonoBitmap = CreateBitmap(bmp.GetWidth(),bmp.GetHeight(),1,1,NULL);
AutoHBITMAP
hMonoBitmap(CreateBitmap(bmp.GetWidth(),bmp.GetHeight(),1,1,NULL));
ICONINFO iconInfo;
wxZeroMemory(iconInfo);
@@ -1664,11 +1665,7 @@ HICON wxBitmapToIconOrCursor(const wxBitmap& bmp,
iconInfo.hbmMask = hMonoBitmap;
iconInfo.hbmColor = hbmp;
HICON hicon = ::CreateIconIndirect(&iconInfo);
::DeleteObject(hMonoBitmap);
return hicon;
return ::CreateIconIndirect(&iconInfo);
}
wxMask* mask = bmp.GetMask();
@@ -1689,7 +1686,8 @@ HICON wxBitmapToIconOrCursor(const wxBitmap& bmp,
iconInfo.yHotspot = hotSpotY;
}
iconInfo.hbmMask = wxInvertMask((HBITMAP)mask->GetMaskBitmap());
AutoHBITMAP hbmpMask(wxInvertMask((HBITMAP)mask->GetMaskBitmap()));
iconInfo.hbmMask = hbmpMask;
iconInfo.hbmColor = GetHbitmapOf(bmp);
// black out the transparent area to preserve background colour, because
@@ -1715,9 +1713,6 @@ HICON wxBitmapToIconOrCursor(const wxBitmap& bmp,
delete mask;
}
// delete the inverted mask bitmap we created as well
::DeleteObject(iconInfo.hbmMask);
return hicon;
}