From 698c0c09aedabc5f0ef0631f896df137bcb86070 Mon Sep 17 00:00:00 2001 From: PB Date: Tue, 17 Sep 2019 19:07:22 +0200 Subject: [PATCH 1/3] Update docs/contributing/binary-compatibility.md Attempt to update the document, some parts of it are still quite outdated (references to Sun/Solaris, ancient GCC and wxWidgets version...). --- docs/contributing/binary-compatibility.md | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/docs/contributing/binary-compatibility.md b/docs/contributing/binary-compatibility.md index b900aaab23..4f3e3915fd 100644 --- a/docs/contributing/binary-compatibility.md +++ b/docs/contributing/binary-compatibility.md @@ -10,8 +10,8 @@ wxWidgets. Releases -------- -General overview of releases can be found in tn0012.txt, but for -completeness the wxWidgets release version number is as follows: +General overview of releases can be found in [wxWidgets naming conventions](about-platform-toolkit-and-library-names.md), +but for completeness the wxWidgets release version number is as follows: 2.6.2 @@ -20,9 +20,9 @@ Where 2 6 2 Major Minor Release -(I.E. Major.Minor.Release). +(i.e. Major.Minor.Release). -All versions with EVEN minor version component (e.g. 2.4.x, 2.6.x etc.) +All versions with EVEN minor version component (e.g. 2.8.x, 3.0.x etc.) are expected to be binary compatible (ODD minors are development versions and the compatibility constraints don't apply to them). Note that by preserving binary compatibility we mean BACKWARDS compatibility only, @@ -37,8 +37,7 @@ also the section about `wxABI_VERSION`. What kind of changes are NOT binary compatible ---------------------------------------------- -If it's still up, the -[KDE guide](http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++) +[The KDE guide](https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B) is a good reference. @@ -68,8 +67,8 @@ Changes which are compatible - Adding a new non-virtual method to an existing class - Adding a new constructor to an existing class - Overriding the implementation of an existing virtual function -(this is considered to be backwards binary compatible until we find a - counter example; currently it's known to work with Apple gcc at least) + (this is considered to be backwards binary compatible until we find a + counter example; currently it's known to work with Apple gcc at least) - Anything which doesn't result in ABI change at all, e.g. adding new macros, constants and, of course, private changes in the implementation @@ -99,7 +98,7 @@ where 2 06 02 Major Minor Release -I.E. it corresponds to the wxWidgets release in (1). +I.e. it corresponds to the wxWidgets release in section Releases. An example of using `wxABI_VERSION` is as follows for symbols only in a 2.6.2 release: @@ -178,11 +177,11 @@ anything which fits the conditions of being `#if`'ed via `wxABI_VERSION` needs to go here also. See 'info ld scripts version' on a GNU system, it's online here: -http://www.gnu.org/software/binutils/manual/ld-2.9.1/html_node/ld_25.html +https://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_node/ld_25.html Or see chapter 5 of the 'Linker and Libraries Guide' for Solaris, available online here: -http://docsun.cites.uiuc.edu/sun_docs/C/solaris_9/SUNWdev/LLM/p1.html +https://docs.oracle.com/cd/E19120-01/open.solaris/819-0690/chapter5-84101/index.html The file has the layout as follows: From 87c1f2302f7e49e100a2326cf6174fb6d2a6dd69 Mon Sep 17 00:00:00 2001 From: PB Date: Tue, 17 Sep 2019 19:45:53 +0200 Subject: [PATCH 2/3] Fix typo in docs/msw/install.md --- docs/msw/install.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/msw/install.md b/docs/msw/install.md index 5a7f34bc2c..9b54f0babd 100644 --- a/docs/msw/install.md +++ b/docs/msw/install.md @@ -572,7 +572,7 @@ application. Advanced Library Configurations {#msw_advanced} =============================== -Build instructions to less common library configuartions using different UI +Build instructions to less common library configurations using different UI backends are avaiable here. @subpage plat_msw_msys2 "Building with Win32 MSys2 backend" From 60dbb7d5bdcfa5338dfb70413b1523a66514d013 Mon Sep 17 00:00:00 2001 From: PB Date: Tue, 17 Sep 2019 19:53:06 +0200 Subject: [PATCH 3/3] Correct the tool path in docs/contributing/how-to-release.md Correct the name and path of the batch file used to build official MSVS binaries. --- docs/contributing/how-to-release.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributing/how-to-release.md b/docs/contributing/how-to-release.md index 03531fe6d0..bac575ada8 100644 --- a/docs/contributing/how-to-release.md +++ b/docs/contributing/how-to-release.md @@ -171,7 +171,7 @@ If either of these are blank they are set to the default install location. To build binaries for a single compiler, open a command prompt (for Visual Studio 2008 only an SDK 6.1 developer's command prompt must be used), -cd to the build\msw\tools\msvs folder and run the batch file 'buildofficial' +cd to the build\tools\msvs folder and run the batch file 'officialbuild' with the vcXXX version number: Visual Studio 2008 vc90