diff --git a/include/wx/stc/stc.h b/include/wx/stc/stc.h index d31b9aa1e8..f052296fb6 100644 --- a/include/wx/stc/stc.h +++ b/include/wx/stc/stc.h @@ -5427,7 +5427,6 @@ protected: void OnMouseRightDown(wxMouseEvent& evt); void OnMouseMove(wxMouseEvent& evt); void OnMouseLeftUp(wxMouseEvent& evt); - void OnMouseRightUp(wxMouseEvent& evt); void OnMouseMiddleUp(wxMouseEvent& evt); void OnContextMenu(wxContextMenuEvent& evt); void OnMouseWheel(wxMouseEvent& evt); diff --git a/interface/wx/stc/stc.h b/interface/wx/stc/stc.h index 1fae3e15e8..e65f64c40e 100644 --- a/interface/wx/stc/stc.h +++ b/interface/wx/stc/stc.h @@ -6437,8 +6437,8 @@ public: @link wxStyledTextCtrl::wxSTC_POPUP_NEVER wxSTC_POPUP_* @endlink constants. @remarks When wxContextMenuEvent is used to create a custom popup menu, - this function should be called with wxSTC_POPUP_NEVER. Otherwise both - the custom and the default popup menus may be shown. + this function should be called with wxSTC_POPUP_NEVER. Otherwise + the default menu will be shown instead of the custom one. */ void UsePopUp(int popUpMode); diff --git a/src/stc/gen_docs.py b/src/stc/gen_docs.py index cb0c1c824d..949040e8e3 100644 --- a/src/stc/gen_docs.py +++ b/src/stc/gen_docs.py @@ -1282,8 +1282,8 @@ extendedDocs = { '@link wxStyledTextCtrl::wxSTC_POPUP_NEVER wxSTC_POPUP_* @endlink constants.', '@remarks', 'When wxContextMenuEvent is used to create a custom popup menu,', - 'this function should be called with wxSTC_POPUP_NEVER. Otherwise both', - 'the custom and the default popup menus may be shown.',), + 'this function should be called with wxSTC_POPUP_NEVER. Otherwise', + 'the default menu will be shown instead of the custom one.',), 'PropertyType': ('The return value will be one of the', diff --git a/src/stc/stc.cpp b/src/stc/stc.cpp index a39575906c..aa08e678f2 100644 --- a/src/stc/stc.cpp +++ b/src/stc/stc.cpp @@ -151,11 +151,7 @@ wxBEGIN_EVENT_TABLE(wxStyledTextCtrl, wxControl) EVT_LEFT_DCLICK (wxStyledTextCtrl::OnMouseLeftDown) EVT_MOTION (wxStyledTextCtrl::OnMouseMove) EVT_LEFT_UP (wxStyledTextCtrl::OnMouseLeftUp) -#if defined(__WXMAC__) - EVT_RIGHT_UP (wxStyledTextCtrl::OnMouseRightUp) -#else EVT_CONTEXT_MENU (wxStyledTextCtrl::OnContextMenu) -#endif EVT_MOUSEWHEEL (wxStyledTextCtrl::OnMouseWheel) EVT_MIDDLE_UP (wxStyledTextCtrl::OnMouseMiddleUp) EVT_CHAR (wxStyledTextCtrl::OnChar) @@ -5211,8 +5207,7 @@ void wxStyledTextCtrl::OnMouseRightDown(wxMouseEvent& evt) { wxPoint pt = evt.GetPosition(); m_swx->DoRightButtonDown(Point(pt.x, pt.y), m_stopWatch.Time(), evt.ShiftDown(), evt.ControlDown(), evt.AltDown()); - // we need to call evt.Skip() to ensure the context menu event - // is generated with wxOSX + // We need to call evt.Skip() to allow generating EVT_CONTEXT_MENU evt.Skip(); } @@ -5227,13 +5222,6 @@ void wxStyledTextCtrl::OnMouseLeftUp(wxMouseEvent& evt) { evt.ControlDown()); } - -void wxStyledTextCtrl::OnMouseRightUp(wxMouseEvent& evt) { - wxPoint pt = evt.GetPosition(); - m_swx->DoContextMenu(Point(pt.x, pt.y)); -} - - void wxStyledTextCtrl::OnMouseMiddleUp(wxMouseEvent& evt) { wxPoint pt = evt.GetPosition(); m_swx->DoMiddleButtonUp(Point(pt.x, pt.y)); diff --git a/src/stc/stc.cpp.in b/src/stc/stc.cpp.in index ef2a55f4d2..a36991f8d1 100644 --- a/src/stc/stc.cpp.in +++ b/src/stc/stc.cpp.in @@ -151,11 +151,7 @@ wxBEGIN_EVENT_TABLE(wxStyledTextCtrl, wxControl) EVT_LEFT_DCLICK (wxStyledTextCtrl::OnMouseLeftDown) EVT_MOTION (wxStyledTextCtrl::OnMouseMove) EVT_LEFT_UP (wxStyledTextCtrl::OnMouseLeftUp) -#if defined(__WXMAC__) - EVT_RIGHT_UP (wxStyledTextCtrl::OnMouseRightUp) -#else EVT_CONTEXT_MENU (wxStyledTextCtrl::OnContextMenu) -#endif EVT_MOUSEWHEEL (wxStyledTextCtrl::OnMouseWheel) EVT_MIDDLE_UP (wxStyledTextCtrl::OnMouseMiddleUp) EVT_CHAR (wxStyledTextCtrl::OnChar) @@ -726,8 +722,7 @@ void wxStyledTextCtrl::OnMouseRightDown(wxMouseEvent& evt) { wxPoint pt = evt.GetPosition(); m_swx->DoRightButtonDown(Point(pt.x, pt.y), m_stopWatch.Time(), evt.ShiftDown(), evt.ControlDown(), evt.AltDown()); - // we need to call evt.Skip() to ensure the context menu event - // is generated with wxOSX + // We need to call evt.Skip() to allow generating EVT_CONTEXT_MENU evt.Skip(); } @@ -742,13 +737,6 @@ void wxStyledTextCtrl::OnMouseLeftUp(wxMouseEvent& evt) { evt.ControlDown()); } - -void wxStyledTextCtrl::OnMouseRightUp(wxMouseEvent& evt) { - wxPoint pt = evt.GetPosition(); - m_swx->DoContextMenu(Point(pt.x, pt.y)); -} - - void wxStyledTextCtrl::OnMouseMiddleUp(wxMouseEvent& evt) { wxPoint pt = evt.GetPosition(); m_swx->DoMiddleButtonUp(Point(pt.x, pt.y)); diff --git a/src/stc/stc.h.in b/src/stc/stc.h.in index 01cf510c5d..0ab26979b4 100644 --- a/src/stc/stc.h.in +++ b/src/stc/stc.h.in @@ -550,7 +550,6 @@ protected: void OnMouseRightDown(wxMouseEvent& evt); void OnMouseMove(wxMouseEvent& evt); void OnMouseLeftUp(wxMouseEvent& evt); - void OnMouseRightUp(wxMouseEvent& evt); void OnMouseMiddleUp(wxMouseEvent& evt); void OnContextMenu(wxContextMenuEvent& evt); void OnMouseWheel(wxMouseEvent& evt);