Remove WXWIN_OS_DESCRIPTION.

This constant wasn't very useful as it contained the description of the OS on
the machine where the library was built, not the one on which the application
using it was running. It also wasn't used anywhere in wxWidgets and apparently
wasn't meant to be used outside of it.

Finally, putting the output of `uname -r` into it created problems with
creating reproducible builds as just a change in the kernel version changed
the build results.

Closes #17002.
This commit is contained in:
Olly Betts
2015-05-22 02:27:27 +02:00
committed by Vadim Zeitlin
parent aa4811cdbb
commit ecf85bf4cb
9 changed files with 5 additions and 38 deletions

13
configure vendored
View File

@@ -37242,19 +37242,6 @@ $as_echo "$as_me: WARNING: GStreamer not available... disabling wxMediaCtrl" >&2
fi fi
if test "$cross_compiling" != "no"; then
OSINFO="\"$host\""
else
OSINFO=`uname -s -r -m`
OSINFO="\"$OSINFO\""
fi
cat >>confdefs.h <<_ACEOF
#define WXWIN_OS_DESCRIPTION $OSINFO
_ACEOF
if test "x$prefix" != "xNONE"; then if test "x$prefix" != "xNONE"; then
wxPREFIX=$prefix wxPREFIX=$prefix
else else

View File

@@ -7395,21 +7395,6 @@ if test "$wxUSE_MEDIACTRL" = "yes" -o "$wxUSE_MEDIACTRL" = "auto"; then
fi fi
fi fi
dnl ---------------------------------------------------------------------------
dnl get the string with OS info - used by wxGetOsDescription() on MacOS X
dnl ---------------------------------------------------------------------------
if test "$cross_compiling" != "no"; then
dnl Use best guess from host as we can't use uname when cross compiling
OSINFO="\"$host\""
else
dnl attualy work out OS version
OSINFO=`uname -s -r -m`
OSINFO="\"$OSINFO\""
fi
AC_DEFINE_UNQUOTED(WXWIN_OS_DESCRIPTION, $OSINFO)
dnl --------------------------------------------------------------------------- dnl ---------------------------------------------------------------------------
dnl define the variable containing the installation prefix (used in dcpsg.cpp) dnl define the variable containing the installation prefix (used in dcpsg.cpp)
dnl --------------------------------------------------------------------------- dnl ---------------------------------------------------------------------------

View File

@@ -33,6 +33,8 @@ Changes in behaviour which may result in build errors
- "webview" library is not included in `wx-config --libs` output any more, you - "webview" library is not included in `wx-config --libs` output any more, you
need to request it explicitly, e.g. `wx-config --libs std,webview`. need to request it explicitly, e.g. `wx-config --libs std,webview`.
- WXWIN_OS_DESCRIPTION doesn't exist any longer, use wxGetOsDescription().
3.1.0: (released 2015-xx-xx) 3.1.0: (released 2015-xx-xx)
---------------------------- ----------------------------

View File

@@ -122,7 +122,6 @@
#define HAVE_LOCALE_T 1 #define HAVE_LOCALE_T 1
#define wxHAS_KQUEUE 1 #define wxHAS_KQUEUE 1
#define WXWIN_OS_DESCRIPTION "Darwin 7.9.0 Power Macintosh"
#define PACKAGE_BUGREPORT "wx-dev@lists.wxwidgets.org" #define PACKAGE_BUGREPORT "wx-dev@lists.wxwidgets.org"
#define PACKAGE_NAME "wxWidgets" #define PACKAGE_NAME "wxWidgets"
#define PACKAGE_STRING "wxWidgets 3.1.0" #define PACKAGE_STRING "wxWidgets 3.1.0"

View File

@@ -29,7 +29,7 @@ include $(CONFIG)
# Directories list for header files # Directories list for header files
INCLUDEDIRS += -I$(WXDIR)/include INCLUDEDIRS += -I$(WXDIR)/include
# Defines for preprocessor # Defines for preprocessor
DEFINES += -DMWIN -D__WXMSW__ -D__WXMICROWIN__ -D__WXUNIVERSAL__ -D__WIN32__ -D__WIN95__ -DHAVE_BOOL -DMICROWIN_TODO=1 -D__UNIX__ -DHAVE_NANOSLEEP -DMICROWIN_NOCONTROLS -D__WXDEBUG__ -DwxSIZE_T_IS_UINT -DWXWIN_OS_DESCRIPTION="\"MicroWindows\"" DEFINES += -DMWIN -D__WXMSW__ -D__WXMICROWIN__ -D__WXUNIVERSAL__ -D__WIN32__ -D__WIN95__ -DHAVE_BOOL -DMICROWIN_TODO=1 -D__UNIX__ -DHAVE_NANOSLEEP -DMICROWIN_NOCONTROLS -D__WXDEBUG__ -DwxSIZE_T_IS_UINT
# Compilation flags for C files OTHER than include directories # Compilation flags for C files OTHER than include directories
CFLAGS += CFLAGS +=

View File

@@ -30,7 +30,7 @@ include $(CONFIG)
# Directories list for header files # Directories list for header files
INCLUDEDIRS += -I$(WXDIR)/include INCLUDEDIRS += -I$(WXDIR)/include
# Defines for preprocessor # Defines for preprocessor
DEFINES += -DMWIN -D__WXMSW__ -D__WXMICROWIN__ -D__WXUNIVERSAL__ -D__WIN32__ -D__WIN95__ -DHAVE_BOOL -DMICROWIN_TODO=1 -D__UNIX__ -DHAVE_NANOSLEEP -DMICROWIN_NOCONTROLS -D__WXDEBUG__ -DwxSIZE_T_IS_UINT -DWXWIN_OS_DESCRIPTION="\"MicroWindows\"" DEFINES += -DMWIN -D__WXMSW__ -D__WXMICROWIN__ -D__WXUNIVERSAL__ -D__WIN32__ -D__WIN95__ -DHAVE_BOOL -DMICROWIN_TODO=1 -D__UNIX__ -DHAVE_NANOSLEEP -DMICROWIN_NOCONTROLS -D__WXDEBUG__ -DwxSIZE_T_IS_UINT
# Compilation flags for C files OTHER than include directories # Compilation flags for C files OTHER than include directories
CFLAGS += CFLAGS +=

View File

@@ -14,9 +14,6 @@
#endif /* __cplusplus */ #endif /* __cplusplus */
/* fill in with the string wxGetOsDescription() will return */
#undef WXWIN_OS_DESCRIPTION
/* the installation location prefix from configure */ /* the installation location prefix from configure */
#undef wxINSTALL_PREFIX #undef wxINSTALL_PREFIX

View File

@@ -30,9 +30,6 @@
#endif /* __cplusplus */ #endif /* __cplusplus */
/* fill in with the string wxGetOsDescription() will return */
#define WXWIN_OS_DESCRIPTION "OpenVMS"
/* the installation location prefix from configure */ /* the installation location prefix from configure */
#undef wxINSTALL_PREFIX #undef wxINSTALL_PREFIX

View File

@@ -274,7 +274,7 @@ include $(CONFIG)
# Directories list for header files # Directories list for header files
INCLUDEDIRS += -I$(WXDIR)/include INCLUDEDIRS += -I$(WXDIR)/include
# Defines for preprocessor # Defines for preprocessor
DEFINES += -DMWIN -D__WXMSW__ -D__WXMICROWIN__ -D__WXUNIVERSAL__ -D__WIN32__ -D__WIN95__ -DHAVE_BOOL -DMICROWIN_TODO=1 -D__UNIX__ -DHAVE_NANOSLEEP -DMICROWIN_NOCONTROLS -D__WXDEBUG__ -DwxSIZE_T_IS_UINT -DWXWIN_OS_DESCRIPTION="\"MicroWindows\"" DEFINES += -DMWIN -D__WXMSW__ -D__WXMICROWIN__ -D__WXUNIVERSAL__ -D__WIN32__ -D__WIN95__ -DHAVE_BOOL -DMICROWIN_TODO=1 -D__UNIX__ -DHAVE_NANOSLEEP -DMICROWIN_NOCONTROLS -D__WXDEBUG__ -DwxSIZE_T_IS_UINT
# Compilation flags for C files OTHER than include directories # Compilation flags for C files OTHER than include directories
CFLAGS += CFLAGS +=