Check for non-null window in wxRendererNative::GetCheckBoxSize()

Instead of running normally under some platforms and crashing under MSW
(when using themes) when passing NULL to GetCheckBoxSize(), now
consistently assert and return zero size everywhere.

Closes #18241.
This commit is contained in:
Vadim Zeitlin
2018-10-11 00:01:00 +02:00
parent a36868b391
commit ea71ea1259
5 changed files with 24 additions and 4 deletions

View File

@@ -551,8 +551,13 @@ wxRendererGTK::DrawComboBoxDropButton(wxWindow *win,
}
wxSize
wxRendererGTK::GetCheckBoxSize(wxWindow *WXUNUSED(win))
wxRendererGTK::GetCheckBoxSize(wxWindow* win)
{
// Even though we don't use the window in this implementation, still check
// that it's valid to avoid surprises when running the same code under the
// other platforms.
wxCHECK_MSG( win, wxSize(0, 0), "Must have a valid window" );
#ifdef __WXGTK3__
int min_width, min_height;
wxGtkStyleContext sc;