Improve wxListBox::GetCountPerPage() in wxGTK and wxOSX

Provide native implementation of this function instead of using the ad hoc one
in common code, which didn't really work -- so remove it completely now.

Closes #17189.

include/wx/gtk/listbox.h

@@ -75,6 +75,7 @@ public:
     virtual void EnsureVisible(int n) wxOVERRIDE;
 
     virtual int GetTopItem() const wxOVERRIDE;
+    virtual int GetCountPerPage() const wxOVERRIDE;
 
     virtual void Update() wxOVERRIDE;
 

include/wx/listbox.h

@@ -73,7 +73,7 @@ public:
     virtual void EnsureVisible(int n);
 
     virtual int GetTopItem() const { return wxNOT_FOUND; }
-    virtual int GetCountPerPage() const;
+    virtual int GetCountPerPage() const { return -1; }
 
     // a combination of Append() and EnsureVisible(): appends the item to the
     // listbox and ensures that it is visible i.e. not scrolled out of view
@@ -136,8 +136,6 @@ protected:
     // single selection mode on platforms other than MSW).
     void UpdateOldSelections();
 
-    wxCoord GetLineHeight() const;
-
 private:
     wxDECLARE_NO_COPY_CLASS(wxListBoxBase);
 };

include/wx/osx/core/private.h

@@ -615,6 +615,7 @@ public:
 
     virtual void            ListScrollTo( unsigned int n ) = 0;
     virtual int             ListGetTopItem() const = 0;
+    virtual int             ListGetCountPerPage() const = 0;
     virtual void            UpdateLine( unsigned int n, wxListWidgetColumn* col = NULL ) = 0;
     virtual void            UpdateLineToEnd( unsigned int n) = 0;
 

include/wx/osx/listbox.h

@@ -109,6 +109,7 @@ public:
     virtual void EnsureVisible(int n) wxOVERRIDE;
 
     virtual int GetTopItem() const wxOVERRIDE;
+    virtual int GetCountPerPage() const wxOVERRIDE;
 
     virtual wxVisualAttributes GetDefaultAttributes() const wxOVERRIDE
     {