Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop using GTK_TREE_VIEW_COLUMN_AUTOSIZE in wxDataViewCtrl

Browse Source 
Using this column type made the control even slower for a big number of items
and also prevented the user from resizing the column which was unexpected.

See #16680.
This commit is contained in:
Vadim Zeitlin
2016-02-28 20:36:03 +01:00
parent c2821dcea0
commit e5507c27a1
1 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/gtk/dataview.cpp
View File

@@ -3309,19 +3309,15 @@ int wxDataViewColumn::GetWidth() const
void wxDataViewColumn::SetWidth( int width ) void wxDataViewColumn::SetWidth( int width )
{ {
if ( width == wxCOL_WIDTH_AUTOSIZE ) // Notice that we don't have anything to do for wxCOL_WIDTH_DEFAULT and
// wxCOL_WIDTH_AUTOSIZE as the native control tries to use the appropriate
// width by default anyhow, don't use GTK_TREE_VIEW_COLUMN_AUTOSIZE to
// force it because, as mentioned in GTK+ documentation, it's completely
// inappropriate for controls with a lot of items (because it's O(N)) and
// it would also prevent the user from resizing the column manually which
// we want to allow for resizeable columns.
if ( width >= 0 )
{ {
// NB: this disables user resizing
gtk_tree_view_column_set_sizing( GTK_TREE_VIEW_COLUMN(m_column), GTK_TREE_VIEW_COLUMN_AUTOSIZE );
}
else
{
if ( width == wxCOL_WIDTH_DEFAULT )
{
// TODO find a better calculation
width = wxDVC_DEFAULT_WIDTH;
}
gtk_tree_view_column_set_sizing( GTK_TREE_VIEW_COLUMN(m_column), GTK_TREE_VIEW_COLUMN_FIXED ); gtk_tree_view_column_set_sizing( GTK_TREE_VIEW_COLUMN(m_column), GTK_TREE_VIEW_COLUMN_FIXED );
gtk_tree_view_column_set_fixed_width( GTK_TREE_VIEW_COLUMN(m_column), width ); gtk_tree_view_column_set_fixed_width( GTK_TREE_VIEW_COLUMN(m_column), width );
} }