Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use wxGtkTreePath instead of calling gtk_tree_path_free()

Browse Source 
Use RAII helper class instead of freeing the object manually.

Also add a couple of "const"s and other minor style fixes.

No real changes.
This commit is contained in:
Vadim Zeitlin
2018-01-24 23:08:15 +01:00
parent 27f705686d
commit e1d8137e70
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/gtk/dataview.cpp
View File

@@ -1902,10 +1902,6 @@ bool wxGtkDataViewModelNotifier::Cleared()
// has been deleted so call row_deleted() for every // has been deleted so call row_deleted() for every
// child of root... // child of root...
int count = m_internal->iter_n_children( NULL ); // number of children of root
GtkTreePath *path = gtk_tree_path_new_first(); // points to root
// It is important to avoid selection changed events being generated from // It is important to avoid selection changed events being generated from
// here as they would reference the already deleted model items, which // here as they would reference the already deleted model items, which
// would result in crashes in any code attempting to handle these events. // would result in crashes in any code attempting to handle these events.
@@ -1917,11 +1913,12 @@ bool wxGtkDataViewModelNotifier::Cleared()
const gint stampOrig = wxgtk_model->stamp; const gint stampOrig = wxgtk_model->stamp;
wxgtk_model->stamp = 0; wxgtk_model->stamp = 0;
int i; {
for (i = 0; i < count; i++) wxGtkTreePath path(gtk_tree_path_new_first()); // points to root
gtk_tree_model_row_deleted( GTK_TREE_MODEL(wxgtk_model), path ); const int count = m_internal->iter_n_children( NULL ); // number of children of root
for (int i = 0; i < count; i++)
gtk_tree_path_free( path ); gtk_tree_model_row_deleted( GTK_TREE_MODEL(wxgtk_model), path );
}
wxgtk_model->stamp = stampOrig; wxgtk_model->stamp = stampOrig;