Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix wxQT crash if wxRadioBox is created without wxRA_SPECIFY_XXX

Browse Source 
Fall back to wxRA_SPECIFY_COLS if neither it nor wxRA_SPECIFY_ROWS is
given instead of not initializing m_qtBoxLayout at all in this case and
subsequently crashing due to it.

Closes https://github.com/wxWidgets/wxWidgets/pull/1125
This commit is contained in:
Graham Dawes
2019-01-09 09:45:02 +00:00
committed by Vadim Zeitlin
parent aa422c6be2
commit dfdbba7ebc
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/qt/radiobox.cpp
View File

@@ -146,6 +146,9 @@ bool wxRadioBox::Create(wxWindow *parent,
m_qtGroupBox->setTitle( wxQtConvertString( title ) ); m_qtGroupBox->setTitle( wxQtConvertString( title ) );
m_qtButtonGroup = new wxQtButtonGroup( m_qtGroupBox, this ); m_qtButtonGroup = new wxQtButtonGroup( m_qtGroupBox, this );
if ( !(style & (wxRA_SPECIFY_ROWS | wxRA_SPECIFY_COLS)) )
style |= wxRA_SPECIFY_COLS;
// wxRA_SPECIFY_COLS means that we arrange buttons in // wxRA_SPECIFY_COLS means that we arrange buttons in
// left to right order and GetMajorDim() is the number of columns while // left to right order and GetMajorDim() is the number of columns while
// wxRA_SPECIFY_ROWS means that the buttons are arranged top to bottom and // wxRA_SPECIFY_ROWS means that the buttons are arranged top to bottom and