diff --git a/include/wx/msw/choice.h b/include/wx/msw/choice.h index d17e1c655d..c124543d15 100644 --- a/include/wx/msw/choice.h +++ b/include/wx/msw/choice.h @@ -12,6 +12,8 @@ #ifndef _WX_CHOICE_H_ #define _WX_CHOICE_H_ +struct tagCOMBOBOXINFO; + // ---------------------------------------------------------------------------- // Choice item // ---------------------------------------------------------------------------- @@ -136,6 +138,10 @@ protected: // set the height of the visible part of the control to m_heightOwn void MSWUpdateVisibleHeight(); + // Call GetComboBoxInfo() and return false if it's not supported by this + // system. Notice that the caller must initialize info.cbSize. + bool MSWGetComboBoxInfo(tagCOMBOBOXINFO* info) const; + // create and initialize the control bool CreateAndInit(wxWindow *parent, wxWindowID id, const wxPoint& pos, diff --git a/src/msw/choice.cpp b/src/msw/choice.cpp index 5ad9416212..e408eb89ad 100644 --- a/src/msw/choice.cpp +++ b/src/msw/choice.cpp @@ -36,6 +36,8 @@ #include "wx/settings.h" #endif +#include "wx/dynlib.h" + #include "wx/msw/private.h" // ============================================================================ @@ -198,6 +200,28 @@ wxChoice::~wxChoice() Clear(); } +bool wxChoice::MSWGetComboBoxInfo(COMBOBOXINFO* info) const +{ + // TODO-Win9x: Get rid of this once we officially drop support for Win9x + // and just call the function directly. +#if wxUSE_DYNLIB_CLASS + typedef BOOL (WINAPI *GetComboBoxInfo_t)(HWND, COMBOBOXINFO*); + static GetComboBoxInfo_t s_pfnGetComboBoxInfo = NULL; + static bool s_triedToLoad = false; + if ( !s_triedToLoad ) + { + s_triedToLoad = true; + wxLoadedDLL dllUser32("user32.dll"); + wxDL_INIT_FUNC(s_pfn, GetComboBoxInfo, dllUser32); + } + + if ( s_pfnGetComboBoxInfo ) + return (*s_pfnGetComboBoxInfo)(GetHwnd(), info) != 0; +#endif // wxUSE_DYNLIB_CLASS + + return false; +} + // ---------------------------------------------------------------------------- // adding/deleting items to/from the list // ---------------------------------------------------------------------------- diff --git a/src/msw/combobox.cpp b/src/msw/combobox.cpp index 46b1c482c1..076f3689ec 100644 --- a/src/msw/combobox.cpp +++ b/src/msw/combobox.cpp @@ -39,7 +39,6 @@ #endif #include "wx/clipbrd.h" -#include "wx/dynlib.h" #include "wx/wupdlock.h" #include "wx/msw/private.h" @@ -378,26 +377,9 @@ bool wxComboBox::MSWShouldPreProcessMessage(WXMSG *pMsg) WXHWND wxComboBox::GetEditHWNDIfAvailable() const { -#if wxUSE_DYNLIB_CLASS -#if defined(WINVER) && WINVER >= 0x0500 - typedef BOOL (WINAPI *GetComboBoxInfo_t)(HWND, COMBOBOXINFO*); - static GetComboBoxInfo_t s_pfnGetComboBoxInfo = NULL; - static bool s_triedToLoad = false; - if ( !s_triedToLoad ) - { - s_triedToLoad = true; - wxLoadedDLL dllUser32("user32.dll"); - wxDL_INIT_FUNC(s_pfn, GetComboBoxInfo, dllUser32); - } - - if ( s_pfnGetComboBoxInfo ) - { - WinStruct info; - (*s_pfnGetComboBoxInfo)(GetHwnd(), &info); + WinStruct info; + if ( MSWGetComboBoxInfo(&info) ) return info.hwndItem; - } -#endif // WINVER >= 0x0500 -#endif // wxUSE_DYNLIB_CLASS if (HasFlag(wxCB_SIMPLE)) {