Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup of wxDataViewCtrl cell activation code.

Browse Source 
Fix confusion of what cell activation is and inconsistence with native
handling in GTK+. Document the distinction between activating (~
editing) a cell and activating (double-clicking) the whole item.

Deprecate wxDataViewCustomRenderer::LeftClick() and Activate() methods,
replace them with single ActivateCell() that is called for both kinds of
activation.

Fix implementations so that ActivateCell() is not called on
double-click, when it shouldn't, and vice versa: don't send
wxEVT_COMMAND_DATAVIEW_ITEM_ACTIVATED for cell activation.

Partially reverts r67099 -- restores old 2.9 signatures of compatibility
LeftClick() and Activate() methods.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@69473 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Václav Slavík
2011-10-19 16:20:17 +00:00
parent 4a99d59750
commit dc73d7f5d4
9 changed files with 229 additions and 167 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
docs/changes.txt
View File

@@ -184,9 +184,13 @@ Changes in behaviour not resulting in compilation errors, please read this!
wxAutomationInstance_SilentIfNone flag to prevent the error message if no
currently running instances of this object are available.
- Signatures of wxDataViewCustomRenderer::Activate(), LeftClick() and
StartDrag() virtual methods changed. You will need to change them in your
derived renderer class too if you override them.
- Signature of wxDataViewCustomRenderer::StartDrag() virtual method changed.
You will need to change it in your derived renderer class too if you override
it.
- wxDataViewCustomRenderer::Activate() and LeftClick() were replaced with the
new ActivateCell() method. You will need to change it in your derived
renderer class accordingly.
- wxThread::Wait() and wxThread::Delete() used to dispatch the events while
waiting for the thread to exit in wxMSW. They still do it in default build
@@ -482,6 +486,7 @@ All (GUI):
- Fix tooltips in wxSearchCtrl and other composite controls (Catalin Raceanu).
- Allow converting to and from wxGraphicsBitmap and wxImage directly.
- Allow wxGraphicsFont creation without passing by wxFont.
- Added wxDataViewCustomRenderer::ActivateCell().
OSX:

12
docs/doxygen/overviews/changes_since28.h
View File

@@ -177,10 +177,14 @@ Finally, a few structure fields, notable @c wxCmdLineEntryDesc::shortName,
available for the scroll target as function of the main window size, please
see the documentation of this method for more details.
- Signatures of wxDataViewCustomRenderer::Activate(),
wxDataViewCustomRenderer::LeftClick() and
wxDataViewCustomRenderer::StartDrag() virtual methods changed. You will need
to change them in your derived renderer class too if you override them.
- Signature of wxDataViewCustomRenderer::StartDrag() virtual method changed.
You will need to change it in your derived renderer class too if you override
it.
- wxDataViewCustomRenderer::Activate() and
wxDataViewCustomRenderer::LeftClick() were replaced with the new
wxDataViewCustomRenderer::ActivateCell() method. You will need to change it
in your derived renderer class accordingly.
*/