Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Show states using names, not ordinals, in trace message

Browse Source 
This is much more readable.
This commit is contained in:
Vadim Zeitlin
2021-03-24 17:29:30 +01:00
parent 0548a06905
commit d7235ebb05
1 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/common/webrequest.cpp
View File

@@ -201,13 +201,34 @@ struct StateEventProcessor
const wxString m_failMsg; const wxString m_failMsg;
}; };
#if wxUSE_LOG_TRACE
// Tiny helper to log states as strings rather than meaningless numbers.
wxString StateName(wxWebRequest::State state)
{
switch ( state )
{
case wxWebRequest::State_Idle: return wxS("IDLE");
case wxWebRequest::State_Unauthorized: return wxS("UNAUTHORIZED");
case wxWebRequest::State_Active: return wxS("ACTIVE");
case wxWebRequest::State_Completed: return wxS("COMPLETED");
case wxWebRequest::State_Failed: return wxS("FAILED");
case wxWebRequest::State_Cancelled: return wxS("CANCELLED");
}
return wxString::Format("invalid state %d", state);
}
#endif // wxUSE_LOG_TRACE
} // anonymous namespace } // anonymous namespace
void wxWebRequestImpl::SetState(wxWebRequest::State state, const wxString & failMsg) void wxWebRequestImpl::SetState(wxWebRequest::State state, const wxString & failMsg)
{ {
wxCHECK_RET( state != m_state, "shouldn't switch to the same state" ); wxCHECK_RET( state != m_state, "shouldn't switch to the same state" );
wxLogTrace(wxTRACE_WEBREQUEST, "Request %p: state %d => %d", this, m_state, state); wxLogTrace(wxTRACE_WEBREQUEST, "Request %p: state %s => %s",
this, StateName(m_state), StateName(state));
m_state = state; m_state = state;