From d4909ffd0767ff6c350243c63f2e87dd4f911726 Mon Sep 17 00:00:00 2001
From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Sat, 19 Feb 2022 14:57:41 +0100
Subject: [PATCH] Remove unnecessary wxBeginBusyCursor() from generic dialogs

For some reason lost in the mist of time (this seems to have started in
92afa2b150 (Did somework on the generic dialogs, Renamed wxBox ->
wxBoxSizer Removed old dialog layout code,, 1999-08-11)) we were setting
busy cursor while creating several generic dialogs.

This is completely useless, so just stop doing it.
---
 src/generic/colrdlgg.cpp | 5 -----
 src/generic/numdlgg.cpp  | 5 -----
 src/generic/textdlgg.cpp | 5 -----
 3 files changed, 15 deletions(-)

diff --git a/src/generic/colrdlgg.cpp b/src/generic/colrdlgg.cpp
index dba671b750..2222b7afbe 100644
--- a/src/generic/colrdlgg.cpp
+++ b/src/generic/colrdlgg.cpp
@@ -16,7 +16,6 @@
 
 #ifndef WX_PRECOMP
     #include "wx/settings.h"
-    #include "wx/utils.h"
     #include "wx/intl.h"
     #include "wx/dialog.h"
     #include "wx/listbox.h"
@@ -316,8 +315,6 @@ void wxGenericColourDialog::CalculateMeasurements()
 
 void wxGenericColourDialog::CreateWidgets()
 {
-    wxBeginBusyCursor();
-
 #if wxCLRDLGG_USE_PREVIEW_WITH_ALPHA
     CreateCustomBitmaps();
 #endif
@@ -402,8 +399,6 @@ void wxGenericColourDialog::CreateWidgets()
     topSizer->Fit( this );
 
     Centre( wxBOTH );
-
-    wxEndBusyCursor();
 }
 
 void wxGenericColourDialog::InitializeColours(void)
diff --git a/src/generic/numdlgg.cpp b/src/generic/numdlgg.cpp
index 9b4fd68895..1096231e69 100644
--- a/src/generic/numdlgg.cpp
+++ b/src/generic/numdlgg.cpp
@@ -25,7 +25,6 @@
 #ifndef WX_PRECOMP
     #include <stdio.h>
 
-    #include "wx/utils.h"
     #include "wx/dialog.h"
     #include "wx/button.h"
     #include "wx/stattext.h"
@@ -86,8 +85,6 @@ bool wxNumberEntryDialog::Create(wxWindow *parent,
     m_max = max;
     m_min = min;
 
-    wxBeginBusyCursor();
-
     wxBoxSizer *topsizer = new wxBoxSizer( wxVERTICAL );
 #if wxUSE_STATTEXT
     // 1) text message
@@ -133,8 +130,6 @@ bool wxNumberEntryDialog::Create(wxWindow *parent,
     m_spinctrl->SetSelection(-1, -1);
     m_spinctrl->SetFocus();
 
-    wxEndBusyCursor();
-
     return true;
 }
 
diff --git a/src/generic/textdlgg.cpp b/src/generic/textdlgg.cpp
index b9d2e10995..9cae084bf1 100644
--- a/src/generic/textdlgg.cpp
+++ b/src/generic/textdlgg.cpp
@@ -25,7 +25,6 @@
 #include "wx/generic/textdlgg.h"
 
 #ifndef WX_PRECOMP
-    #include "wx/utils.h"
     #include "wx/dialog.h"
     #include "wx/button.h"
     #include "wx/stattext.h"
@@ -85,8 +84,6 @@ bool wxTextEntryDialog::Create(wxWindow *parent,
     m_dialogStyle = style;
     m_value = value;
 
-    wxBeginBusyCursor();
-
     wxBoxSizer *topsizer = new wxBoxSizer( wxVERTICAL );
 
     wxSizerFlags flagsBorder2;
@@ -127,8 +124,6 @@ bool wxTextEntryDialog::Create(wxWindow *parent,
     if ( style & wxCENTRE )
         Centre( wxBOTH );
 
-    wxEndBusyCursor();
-
     return true;
 }