Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize memory allocation in wxArrayString ctors

Browse Source 
Call assign() instead of Add() in a loop: this is not only shorter, but
also ensures that reserve() is called before starting the loop and all
the required memory is allocated at once.
This commit is contained in:
Vadim Zeitlin
2017-11-19 21:37:49 +01:00
parent 876090aeea
commit d3132b114c
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/common/arrstr.cpp
View File

@@ -36,8 +36,7 @@ wxArrayString::wxArrayString(size_t sz, const char** a)
#if !wxUSE_STD_CONTAINERS #if !wxUSE_STD_CONTAINERS
Init(false); Init(false);
#endif #endif
for (size_t i=0; i < sz; i++) assign(a, a + sz);
Add(a[i]);
} }
wxArrayString::wxArrayString(size_t sz, const wchar_t** a) wxArrayString::wxArrayString(size_t sz, const wchar_t** a)
@@ -45,8 +44,7 @@ wxArrayString::wxArrayString(size_t sz, const wchar_t** a)
#if !wxUSE_STD_CONTAINERS #if !wxUSE_STD_CONTAINERS
Init(false); Init(false);
#endif #endif
for (size_t i=0; i < sz; i++) assign(a, a + sz);
Add(a[i]);
} }
wxArrayString::wxArrayString(size_t sz, const wxString* a) wxArrayString::wxArrayString(size_t sz, const wxString* a)
@@ -54,8 +52,7 @@ wxArrayString::wxArrayString(size_t sz, const wxString* a)
#if !wxUSE_STD_CONTAINERS #if !wxUSE_STD_CONTAINERS
Init(false); Init(false);
#endif #endif
for (size_t i=0; i < sz; i++) assign(a, a + sz);
Add(a[i]);
} }
#if !wxUSE_STD_CONTAINERS #if !wxUSE_STD_CONTAINERS