Check index value with CHECK_MSG to avoid crashes

2020-02-09 20:39:06 +01:00
parent 0b7f1e7e91
commit c7c3f337c2
1 changed files with 2 additions and 1 deletions
--- a/include/wx/propgrid/propgrid.h
+++ b/include/wx/propgrid/propgrid.h
@@ -1155,6 +1155,7 @@ public:

    const wxPGCommonValue* GetCommonValue( unsigned int i ) const
    {
+        wxCHECK_MSG( i < m_commonValues.size(), NULL, "Invalid item index" );
        return m_commonValues[i];
    }

@@ -1167,7 +1168,7 @@ public:
    // Returns label of given common value.
    wxString GetCommonValueLabel( unsigned int i ) const
    {
-        wxASSERT( GetCommonValue(i) );
+        wxCHECK_MSG( i < m_commonValues.size(), wxString(), "Invalid item index" );
        return GetCommonValue(i)->GetLabel();
    }