Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix swapped numerator and denominator in the equation

Browse Source 
tan(a/2) = sin(a) / (1 + cos(a)), so 1/tan(a/2) = 1 / sin(a) * (1 + cos(a))

See #18142.
This commit is contained in:
Artur Wieczorek
2018-06-27 22:36:57 +02:00
parent 2842108e24
commit c716b59783
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/graphcmn.cpp
View File

@@ -487,7 +487,7 @@ void wxGraphicsPathData::AddArcToPoint( wxDouble x1, wxDouble y1 , wxDouble x2,
bool drawClockwiseArc = v1.GetCrossProduct(v2) < 0;
alpha = wxDegToRad(alpha);
wxDouble distT = r / (1.0 + cos(alpha)) * sin(alpha); // = r / tan(a/2) = r / sin(a/2) * cos(a/2)
wxDouble distT = r / sin(alpha) * (1.0 + cos(alpha)); // = r / tan(a/2) = r / sin(a/2) * cos(a/2)
wxDouble distC = r / sin(alpha / 2.0);
wxASSERT_MSG( distT <= v1Length && distT <= v2Length,
wxS("Radius is too big to fit the arc to given points") );