Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix off by 1 error in buffer size in wxOSX wxDropTarget code.

Browse Source 
The size of the buffer used for the data currently needs to include an extra
byte for the trailing NUL. This is wrong, as it means that GetDataSize() and
GetDataHere() behaviour is not consistent, but at least avoid overrunning the
buffer for now.

Also use wxCharBuffer instead of raw char array to make the code safer (both
because it releases the memory automatically and because it also adds an extra
byte for the trailing NUL automatically as well, making such bugs impossible).

See #15914.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/branches/WX_3_0_BRANCH@76050 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2014-03-02 15:50:17 +00:00
parent d30a02642d
commit c61ae4d190
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/changes.txt
View File

@@ -639,6 +639,7 @@ wxMSW:
wxOSX:
- Fix buffer overrun in drag-and-drop code (Kristian Duske).
- Fix incorrect joystick detection in configure (Lauri Nurmi).
- Fix crash in wxDataViewCtrl when cancelling choice selection (hartwigw).
- Implement support for wxGA_VERTICAL in wxGauge (themindiswatching).