From c606a7fc9fac100dbf795fa66c83c5368c9c5d00 Mon Sep 17 00:00:00 2001 From: Artur Wieczorek Date: Sat, 10 Nov 2018 20:40:59 +0100 Subject: [PATCH] Store format as wxString Using wxString here is simpler and not misleading. --- src/propgrid/advprops.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/propgrid/advprops.cpp b/src/propgrid/advprops.cpp index 9ff59a10cf..f65cc49918 100644 --- a/src/propgrid/advprops.cpp +++ b/src/propgrid/advprops.cpp @@ -2294,8 +2294,6 @@ bool wxDateProperty::StringToValue( wxVariant& variant, const wxString& text, wxString wxDateProperty::ValueToString( wxVariant& value, int argFlags ) const { - const wxChar* format = (const wxChar*) NULL; - wxDateTime dateTime = value.GetDateTime(); if ( !dateTime.IsValid() ) @@ -2311,13 +2309,14 @@ wxString wxDateProperty::ValueToString( wxVariant& value, ms_defaultDateFormat = DetermineDefaultDateFormat( showCentury ); } + wxString format; if ( !m_format.empty() && !(argFlags & wxPG_FULL_VALUE) ) - format = m_format.c_str(); + format = m_format; // Determine default from locale - if ( !format ) - format = ms_defaultDateFormat.c_str(); + if ( format.empty() ) + format = ms_defaultDateFormat; return dateTime.Format(format); }